Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add codecov token to yaml #85

Merged
merged 2 commits into from
Jun 6, 2024
Merged

CI: Add codecov token to yaml #85

merged 2 commits into from
Jun 6, 2024

Conversation

nawtrey
Copy link
Collaborator

@nawtrey nawtrey commented Jun 5, 2024

Description

  • Add the codecov token to the yaml so reports can be properly uploaded
    to codecov

See my original comment here.

Status

  • Ready to go

@nawtrey
CI: Add codecov token to yaml
eae7f9a 
* Add the codecov token to the yaml
so reports can be properly uploaded
to codecov
@nawtrey nawtrey added the CI Continuous integration label Jun 5, 2024
@nawtrey
Copy link
Collaborator Author

nawtrey commented Jun 5, 2024

The codecov log shows the reports are now successfully uploading, but codecov is saying there is an "unknown error". I'm not sure if it's related, but I'm still using codecov/codecov-action@v1. I think I'll fork from the last commit with a good report and see if I can get it working.

@nawtrey
Copy link
Collaborator Author

nawtrey commented Jun 6, 2024

Okay everything looks good here now. Merging.

@nawtrey nawtrey merged commit 44f4dc4 into master Jun 6, 2024
5 checks passed
@nawtrey nawtrey deleted the add_codecov_token branch June 6, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nawtrey