Add Second_Of_Minute Function As An Alias Of The Second Function #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Codecov Report
@@ Coverage Diff @@
## integ-add-second_of_minute-function #197 +/- ##
======================================================================
Coverage ? 95.82%
Complexity ? 3542
======================================================================
Files ? 356
Lines ? 9400
Branches ? 674
======================================================================
Hits ? 9008
Misses ? 334
Partials ? 58
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
MitchellGale
approved these changes
Dec 23, 2022
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
margarit-h
reviewed
Dec 27, 2022
| @@ -831,6 +831,63 @@ public void second() { | |||
| assertEquals("second(DATETIME '2020-08-17 01:02:03')", expression.toString()); | |||
| } | |||
|
|
|||
| public void testSecondOfMinute(FunctionExpression dateExpression, int second, String testExpr) { | |||
There was a problem hiding this comment.
Seems like both this method and testInvalidSecondOfMinute could be private.
margarit-h
approved these changes
Dec 27, 2022
GumpacG
approved these changes
Dec 27, 2022
acarbonetto
approved these changes
Dec 29, 2022
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
GabeFernandez310
force-pushed
the
dev-add-second_of_minute-function
branch
from
166189c to
4767c53
Compare
core/src/main/java/org/opensearch/sql/expression/datetime/DateTimeFunction.java
Show resolved
Hide resolved
core/src/test/java/org/opensearch/sql/expression/datetime/DateTimeFunctionTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Yury-Fridlyand
approved these changes
Jan 5, 2023
Comment on lines
907
to
913
|
|
||
|
|
||
|
|
||
|
|
||
| } | ||
|
|
||
|
|
Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the
second_of_minutefunction as an alias for thesecondfunction which currently exists in opensearchIssues Resolved
#722
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.