Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support date and time functions #722

Closed
80 of 87 tasks
Yury-Fridlyand opened this issue Aug 3, 2022 · 2 comments
Closed
80 of 87 tasks

[FEATURE] Support date and time functions #722

Yury-Fridlyand opened this issue Aug 3, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request v2.7.0

Comments

@Yury-Fridlyand
Copy link
Collaborator

Yury-Fridlyand commented Aug 3, 2022

Copied from opendistro-for-elasticsearch/sql#709.

Implementation should match MySQL standard: https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html

Further improvements:

@Yury-Fridlyand Yury-Fridlyand added enhancement New feature or request untriaged labels Aug 3, 2022
@Yury-Fridlyand Yury-Fridlyand self-assigned this Sep 20, 2022
@GabeFernandez310
Copy link
Contributor

Date_format may need to be fixed to deprecate legacy. There are legacy tests which fail in the new engine if legacy is disabled (possibly due to the lack of support for a 3rd argument for a timezone).

These include the following in DateFormatIT:

  • DateFormatIT. and
  • DateFormatIT. equalTo
  • DateFormatIT. greaterThan
  • DateFormatIT. greaterThanOrEqualTo
  • DateFormatIT. lessThan
  • DateFormatIT. lessThanOrEqualTo
  • DateFormatIT. or
  • DateFormatIT. sortByDateFormat

@Yury-Fridlyand
Copy link
Collaborator Author

Closed as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.7.0
Projects
None yet
Development

No branches or pull requests

4 participants