Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added COSH to V2 engine #244

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Added COSH to V2 engine #244

merged 3 commits into from
Mar 13, 2023

Conversation

matthewryanwells
Copy link

@matthewryanwells matthewryanwells commented Mar 9, 2023

Description

Added math function COSH to V2 engine, updated documentation, and added unit/IT tests

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #244 (a2718fb) into integ-cosh (ef38389) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             integ-cosh     #244   +/-   ##
=============================================
  Coverage         98.38%   98.38%           
- Complexity         3698     3701    +3     
=============================================
  Files               343      343           
  Lines              9121     9126    +5     
  Branches            586      586           
=============================================
+ Hits               8974     8979    +5     
  Misses              142      142           
  Partials              5        5           
Flag Coverage Δ
sql-engine 98.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø)
...ssion/operator/arthmetic/MathematicalFunction.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@matthewryanwells matthewryanwells changed the title Updated COSH to V2 engine Added COSH to V2 engine Mar 9, 2023
@matthewryanwells matthewryanwells merged commit 2d0e1db into integ-cosh Mar 13, 2023
@matthewryanwells matthewryanwells deleted the dev-cosh branch March 13, 2023 16:23
matthewryanwells added a commit that referenced this pull request Mar 15, 2023
* Added COSH to V2 engine, updated documentation, unit/IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
matthewryanwells added a commit that referenced this pull request Apr 20, 2023
* Added COSH to V2 engine, updated documentation, unit/IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit 8dad71f)
Yury-Fridlyand pushed a commit that referenced this pull request May 1, 2023
…project#1565)

* Added COSH to V2 engine, updated documentation, unit/IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit 8dad71f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants