Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Added COSH to V2 engine #1565

Merged

Conversation

matthewryanwells
Copy link
Contributor

@matthewryanwells matthewryanwells commented Apr 20, 2023

Description

Backporting #1428 to 2.x

Issues Resolved

#1190

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Added COSH to V2 engine, updated documentation, unit/IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit 8dad71f)
@matthewryanwells matthewryanwells requested a review from a team as a code owner April 20, 2023 15:53
@codecov-commenter
Copy link

Codecov Report

Merging #1565 (e59b78f) into 2.x (56eea47) will decrease coverage by 1.28%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #1565      +/-   ##
============================================
- Coverage     98.46%   97.19%   -1.28%     
- Complexity     3867     4107     +240     
============================================
  Files           345      371      +26     
  Lines          9600    10464     +864     
  Branches        616      706      +90     
============================================
+ Hits           9453    10170     +717     
- Misses          142      287     +145     
- Partials          5        7       +2     
Flag Coverage Δ
sql-engine 97.19% <100.00%> (-1.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø)
...ssion/operator/arthmetic/MathematicalFunction.java 100.00% <100.00%> (ø)

... and 59 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@matthewryanwells
Copy link
Contributor Author

matthewryanwells commented Apr 20, 2023

@rupal-bq @chenqi0805 @penghuo This was missed from being added to 2.7, should we add it in now?

Edit: this isn't a very important ticket so it doesn't greatly matter if it gets in or not but would be nice

@dai-chen dai-chen added the enhancement New feature or request label Apr 20, 2023
@dai-chen dai-chen merged commit aa5b3e0 into opensearch-project:2.x Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants