-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for date_nanos
and tests.
#337
Add support for date_nanos
and tests.
#337
Conversation
Codecov Report
@@ Coverage Diff @@
## integ-add-date-nanos-2.x #337 +/- ##
===========================================================
Coverage 97.51% 97.51%
Complexity 4656 4656
===========================================================
Files 408 408
Lines 11930 11931 +1
Branches 829 829
===========================================================
+ Hits 11634 11635 +1
Misses 289 289
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
integ-test/src/test/resources/indexDefinitions/datatypes_index_mapping.json
Outdated
Show resolved
Hide resolved
@Yury-Fridlyand we should add tests to parallel the expected features of date_nanos.
|
+ " FROM %s", TEST_INDEX_DATE_FORMATS); | ||
JSONObject result = executeQuery(query); | ||
verifySchema(result, | ||
schema("hour_minute_second_OR_t_time", null, "time")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change this to hour_minute_second_millis
instead? The point of using the date_nano
type is to include fractions of a second.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use t_time
here, it includes up to 9 digits of fsp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but the verifyDataRows doesn't include any units of precision? Maybe include data that has fractions of a second?
b480916
to
5381a6f
Compare
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
7a04f82
to
25a2007
Compare
Added tests and rebased on upstream/main. |
8ef676b
into
integ-add-date-nanos-2.x
* Add support for `date_nanos` and tests. (#337) * Add support for `date_nanos` and tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add more IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix in IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR feedback. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Spotless Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add support for `date_nanos` and tests. (#337) * Add support for `date_nanos` and tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add more IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix in IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR feedback. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Spotless Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 752da21) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…) (opensearch-project#2020) * Add support for `date_nanos` and tests. (#337) * Add support for `date_nanos` and tests. * Add more IT. --------- * Typo fix in IT. * Address PR feedback. * Spotless --------- (cherry picked from commit 752da21) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Restore support for
date_nanos
type. Initially was added in opensearch-project#360 and removed in opensearch-project#1314 by mistake.Issues Resolved
opensearch-project#1954
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.