Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for date_nanos and tests. (#337) #1976

Merged

Conversation

Yury-Fridlyand
Copy link
Collaborator

Description

Restore support for date_nanos type. Initially was added in #360 and removed in #1314 by mistake.

Please, see team review and discussion in Bit-Quill#337

Issues Resolved

Fixes #1954

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Add support for `date_nanos` and tests.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Add more IT.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…s-2.x

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
GumpacG
GumpacG previously approved these changes Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1976 (f45de5d) into main (491a73b) will increase coverage by 0.00%.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #1976   +/-   ##
=========================================
  Coverage     97.51%   97.52%           
+ Complexity     4656     4655    -1     
=========================================
  Files           408      408           
  Lines         11932    11953   +21     
  Branches        829      829           
=========================================
+ Hits          11636    11657   +21     
  Misses          289      289           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...h/sql/opensearch/data/type/OpenSearchDataType.java 100.00% <100.00%> (ø)

... and 70 files with indirect coverage changes

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
GumpacG
GumpacG previously approved these changes Aug 16, 2023
acarbonetto
acarbonetto previously approved these changes Aug 17, 2023
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
acarbonetto
acarbonetto previously approved these changes Aug 17, 2023
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand merged commit 752da21 into opensearch-project:main Aug 21, 2023
14 of 15 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the integ-add-date-nanos-2.x branch August 21, 2023 16:40
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-1976-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 752da2154d337c74ce60752fe8e47b97ea182bb3
# Push it to GitHub
git push --set-upstream origin backport/backport-1976-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1976-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.9 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.9 2.9
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.9
# Create a new branch
git switch --create backport/backport-1976-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 752da2154d337c74ce60752fe8e47b97ea182bb3
# Push it to GitHub
git push --set-upstream origin backport/backport-1976-to-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.9

Then, create a pull request where the base branch is 2.9 and the compare/head branch is backport/backport-1976-to-2.9.

@acarbonetto acarbonetto added the v2.9.1 Issues targeting release v2.9.1 label Aug 22, 2023
Yury-Fridlyand added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 22, 2023
* Add support for `date_nanos` and tests. (#337)

* Add support for `date_nanos` and tests.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Add more IT.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Typo fix in IT.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Address PR feedback.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Spotless

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 752da21)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
acarbonetto pushed a commit that referenced this pull request Aug 22, 2023
* Add support for `date_nanos` and tests. (#337)

* Add support for `date_nanos` and tests.



* Add more IT.



---------



* Typo fix in IT.



* Address PR feedback.



* Spotless



---------


(cherry picked from commit 752da21)

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 22, 2023
* Add support for `date_nanos` and tests. (#337)

* Add support for `date_nanos` and tests.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Add more IT.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Typo fix in IT.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Address PR feedback.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Spotless

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 752da21)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Yury-Fridlyand pushed a commit that referenced this pull request Aug 23, 2023
* Add support for `date_nanos` and tests. (#337)

* Add support for `date_nanos` and tests.



* Add more IT.



---------



* Typo fix in IT.



* Address PR feedback.



* Spotless



---------


(cherry picked from commit 752da21)

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.9 v2.9.1 Issues targeting release v2.9.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Schema returned by SQL plugin are missing date_nanos fields
6 participants