-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for date_nanos
and tests. (#337)
#1976
Add support for date_nanos
and tests. (#337)
#1976
Conversation
* Add support for `date_nanos` and tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add more IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…s-2.x Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Codecov Report
@@ Coverage Diff @@
## main #1976 +/- ##
=========================================
Coverage 97.51% 97.52%
+ Complexity 4656 4655 -1
=========================================
Files 408 408
Lines 11932 11953 +21
Branches 829 829
=========================================
+ Hits 11636 11657 +21
Misses 289 289
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
48592c5
752da21
into
opensearch-project:main
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-1976-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 752da2154d337c74ce60752fe8e47b97ea182bb3
# Push it to GitHub
git push --set-upstream origin backport/backport-1976-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.9 2.9
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.9
# Create a new branch
git switch --create backport/backport-1976-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 752da2154d337c74ce60752fe8e47b97ea182bb3
# Push it to GitHub
git push --set-upstream origin backport/backport-1976-to-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.9 Then, create a pull request where the |
* Add support for `date_nanos` and tests. (#337) * Add support for `date_nanos` and tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add more IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix in IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR feedback. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Spotless Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 752da21) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add support for `date_nanos` and tests. (#337) * Add support for `date_nanos` and tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add more IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix in IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR feedback. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Spotless Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 752da21) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add support for `date_nanos` and tests. (#337) * Add support for `date_nanos` and tests. * Add more IT. --------- * Typo fix in IT. * Address PR feedback. * Spotless --------- (cherry picked from commit 752da21) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Restore support for
date_nanos
type. Initially was added in #360 and removed in #1314 by mistake.Please, see team review and discussion in Bit-Quill#337
Issues Resolved
Fixes #1954
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.