Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): add multiple options to RollupFilter #592

Merged
merged 20 commits into from
Nov 8, 2024

Conversation

xFJA
Copy link
Collaborator

@xFJA xFJA commented Oct 12, 2024

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

THIS PR BUILDS ON TOP OF #590

The RollupFilter is able to select multiple rollups. Some changes have been required:

  • The Dropdown component has a new prop multiple that enables the multiple selection
  • The from query param passed to the withFilters in the API has been refactored to a string joined by , of all from addresses associated to the rollups selected
  • Created useOverflow hook to detect the overflow in the RollupFilter by applying an opacity linear gradient at the right end
  • Add new optional prop to Option type in Dropdown to be able to customize the component used for the option displayed in the input

Related Issue

Closes #545

Screenshots

Screen.Recording.2024-10-12.at.20.mp4

@xFJA xFJA self-assigned this Oct 12, 2024
Copy link

changeset-bot bot commented Oct 12, 2024

🦋 Changeset detected

Latest commit: 82d3875

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@blobscan/web Minor
@blobscan/api Minor
@blobscan/rest-api-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 0:52am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 0:52am
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 0:52am
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 0:52am
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 0:52am
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 0:52am

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 98.34254% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.14%. Comparing base (aced873) to head (82d3875).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/api/src/utils/count.ts 94.11% 2 Missing ⚠️
packages/db/prisma/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
+ Coverage   89.09%   89.14%   +0.05%     
==========================================
  Files         155      155              
  Lines       10423    10492      +69     
  Branches     1170     1187      +17     
==========================================
+ Hits         9286     9353      +67     
- Misses       1137     1139       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 12, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 334.39 KB (🔴 +88.77 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/block_neighbor 251 B 334.63 KB 95.61%
/stats 347.94 KB 682.33 KB 194.95%

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 353.02 KB 687.41 KB 196.40% (🟢 -4.66%)
/address/[address] 28.53 KB 362.92 KB 103.69% (🟢 -4.34%)
/blob/[hash] 29.22 KB 363.61 KB 103.89% (🟢 -3.78%)
/blobs 79.05 KB 413.43 KB 118.12% (🟡 +13.21%)
/block/[id] 14.9 KB 349.28 KB 99.80% (🟢 -4.00%)
/blocks 76.75 KB 411.13 KB 117.47% (🟡 +13.19%)
/tx/[hash] 17.29 KB 351.67 KB 100.48% (🟡 +1.15%)
/txs 76.25 KB 410.64 KB 117.32% (🟡 +11.19%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@xFJA xFJA marked this pull request as draft October 13, 2024 09:09
@xFJA xFJA marked this pull request as ready for review October 13, 2024 10:34
@xFJA xFJA changed the base branch from main to perf/leverage-stats-tables October 13, 2024 10:34
Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job.

Left some comments

.changeset/old-pianos-help.md Outdated Show resolved Hide resolved
apps/web/src/components/Dropdown/index.tsx Show resolved Hide resolved
apps/web/src/components/Dropdown/index.tsx Outdated Show resolved Hide resolved
apps/web/src/components/Layouts/PaginatedListLayout.tsx Outdated Show resolved Hide resolved
packages/api/src/middlewares/withFilters.ts Outdated Show resolved Hide resolved
packages/api/src/middlewares/withFilters.ts Outdated Show resolved Hide resolved
xFJA and others added 3 commits November 5, 2024 15:46
* fix(web): apply same size styles to Mode & Linea rollups

* feat(web): add Camp rollup icon & update styles

* refactor(web): improve RollupBadge colors

* feat(web): add Paradex rollup icon & update styles

* chore(web): update changeset

* chore(web): optimize rollup icon svgs

---------

Co-authored-by: PJColombo <paulo.colombo@pm.me>
packages/api/test/test-suites/filters.ts Outdated Show resolved Hide resolved
packages/api/src/middlewares/withFilters.ts Outdated Show resolved Hide resolved
@PJColombo PJColombo merged commit 76bd799 into main Nov 8, 2024
14 checks passed
@PJColombo PJColombo deleted the multiple-rollups-filter branch November 8, 2024 12:59
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to select multiple rollups when filtering elements
3 participants