-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): add multiple options to RollupFilter #592
Conversation
🦋 Changeset detectedLatest commit: 82d3875 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
==========================================
+ Coverage 89.09% 89.14% +0.05%
==========================================
Files 155 155
Lines 10423 10492 +69
Branches 1170 1187 +17
==========================================
+ Hits 9286 9353 +67
- Misses 1137 1139 +2 ☔ View full report in Codecov by Sentry. |
📦 Next.js Bundle Analysis for @blobscan/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
334.39 KB (🔴 +88.77 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
New Pages Added
The following pages were added to the bundle from the code in this PR:
Page | Size (compressed) | First Load | % of Budget (350 KB ) |
---|---|---|---|
/block_neighbor |
251 B |
334.63 KB | 95.61% |
/stats |
347.94 KB |
682.33 KB | 194.95% |
Eight Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load | % of Budget (350 KB ) |
---|---|---|---|
/ |
353.02 KB |
687.41 KB | 196.40% (🟢 -4.66%) |
/address/[address] |
28.53 KB |
362.92 KB | 103.69% (🟢 -4.34%) |
/blob/[hash] |
29.22 KB |
363.61 KB | 103.89% (🟢 -3.78%) |
/blobs |
79.05 KB |
413.43 KB | 118.12% (🟡 +13.21%) |
/block/[id] |
14.9 KB |
349.28 KB | 99.80% (🟢 -4.00%) |
/blocks |
76.75 KB |
411.13 KB | 117.47% (🟡 +13.19%) |
/tx/[hash] |
17.29 KB |
351.67 KB | 100.48% (🟡 +1.15%) |
/txs |
76.25 KB |
410.64 KB | 117.32% (🟡 +11.19%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job.
Left some comments
…ollup, or timestamp filters only Enhances performance by fetching counts directly from the stats table when counting elements with filters applied exclusively to 'category', 'rollup', or 'timestamp'.
* fix(web): apply same size styles to Mode & Linea rollups * feat(web): add Camp rollup icon & update styles * refactor(web): improve RollupBadge colors * feat(web): add Paradex rollup icon & update styles * chore(web): update changeset * chore(web): optimize rollup icon svgs --------- Co-authored-by: PJColombo <paulo.colombo@pm.me>
…ve selected options styles
200b068
to
87edd24
Compare
…ses are provided
Checklist
Description
THIS PR BUILDS ON TOP OF #590
The
RollupFilter
is able to select multiple rollups. Some changes have been required:Dropdown
component has a new propmultiple
that enables the multiple selectionfrom
query param passed to thewithFilters
in theAPI
has been refactored to a string joined by,
of all from addresses associated to the rollups selecteduseOverflow
hook to detect the overflow in theRollupFilter
by applying an opacity linear gradient at the right endOption
type inDropdown
to be able to customize the component used for the option displayed in the inputRelated Issue
Closes #545
Screenshots
Screen.Recording.2024-10-12.at.20.mp4