-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(web): Improve rollup badge #603
Conversation
🦋 Changeset detectedLatest commit: 6f1048e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## multiple-rollups-filter #603 +/- ##
==========================================================
Coverage ? 89.15%
==========================================================
Files ? 155
Lines ? 10380
Branches ? 1174
==========================================================
Hits ? 9254
Misses ? 1126
Partials ? 0 ☔ View full report in Codecov by Sentry. |
📦 Next.js Bundle Analysis for @blobscan/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
283.97 KB (🟡 +38.35 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
New Pages Added
The following pages were added to the bundle from the code in this PR:
Page | Size (compressed) | First Load | % of Budget (350 KB ) |
---|---|---|---|
/block_neighbor |
251 B |
284.21 KB | 81.20% |
/stats |
347.92 KB |
631.89 KB | 180.54% |
Eight Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load | % of Budget (350 KB ) |
---|---|---|---|
/ |
353.23 KB |
637.2 KB | 182.06% (🟢 -4.60%) |
/address/[address] |
28.71 KB |
312.68 KB | 89.34% (🟢 -4.29%) |
/blob/[hash] |
29.39 KB |
313.36 KB | 89.53% (🟢 -3.73%) |
/blobs |
79 KB |
362.97 KB | 103.70% (🟡 +13.20%) |
/block/[id] |
15.1 KB |
299.06 KB | 85.45% (🟢 -3.94%) |
/blocks |
76.7 KB |
360.67 KB | 103.05% (🟡 +13.18%) |
/tx/[hash] |
17.05 KB |
301.02 KB | 86.01% (🟡 +1.08%) |
/txs |
76.2 KB |
360.17 KB | 102.91% (🟡 +11.17%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
Nice job! I pushed a commit optimising the svgs sizes. LGTM. Feel free to merge this 👍 |
* fix(web): apply same size styles to Mode & Linea rollups * feat(web): add Camp rollup icon & update styles * refactor(web): improve RollupBadge colors * feat(web): add Paradex rollup icon & update styles * chore(web): update changeset * chore(web): optimize rollup icon svgs --------- Co-authored-by: PJColombo <paulo.colombo@pm.me>
* fix(dayjs): do not return default value when trying to convert a date to daily date * perf(api): optimize count retrieval using stats table for category, rollup, or timestamp filters only Enhances performance by fetching counts directly from the stats table when counting elements with filters applied exclusively to 'category', 'rollup', or 'timestamp'. * feat(web): add multiple prop to Dropdown * feat(web): add multi select prop to RollupFilter * fix(web): add check in RollupFilter to make none option unique * fix(web): add a linear opacity gradient to RollupFilter overflow * chore(web): update changeset * fix(web): simplify Dropdown multiple props strategy * fix(web): add horizontal scroll on Dropdown overflow * chore(web): update changeset with API changes * refactor(web): refactor Dropdown Option type prop * refactor(web): remove not needed Dropdown prop * fix(web): remove empty from addresses in filters * refactor(web): Improve rollup badge (#603) * fix(web): apply same size styles to Mode & Linea rollups * feat(web): add Camp rollup icon & update styles * refactor(web): improve RollupBadge colors * feat(web): add Paradex rollup icon & update styles * chore(web): update changeset * chore(web): optimize rollup icon svgs --------- Co-authored-by: PJColombo <paulo.colombo@pm.me> * fix(web): highlight dropdown options background only on hover + improve selected options styles * fix(web): fix tx & blob count tests after adding multiple from addresses * test: re-add missing test * fix(api): add support for counting multiple rollups in `getCount` procedures * refactor(api): use the `IN` clause for filtering when multiple addresses are provided --------- Co-authored-by: PJColombo <paulo.colombo@pm.me>
Checklist
Description
RollupBadge
colorsParadex
andCamp
rollupsRelated Issue
Closes #482
Screenshots