Skip to content

Commit

Permalink
Use dependencies correctly
Browse files Browse the repository at this point in the history
  • Loading branch information
FrancescAlted committed Sep 27, 2023
1 parent 4982801 commit f46c829
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 17 deletions.
20 changes: 4 additions & 16 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,6 @@ jobs:
with:
submodules: 'recursive'

# - uses: conda-incubator/setup-miniconda@v2
# with:
# auto-update-conda: true
# python-version: ${{ matrix.python-version }}

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
Expand All @@ -29,21 +24,14 @@ jobs:
- name: Install Ninja
uses: seanmiddleditch/gha-setup-ninja@master

- name: Install dependencies
- name: Build
run: |
python -m pip install --upgrade pip
python -m pip install -r requirements-build.txt
python -m pip install -r requirements-tests.txt
# For some reason, the created ndindex wheel issues the next error on Win:
# ImportError: DLL load failed while importing ndindex: %1 is not a valid Win32 application.
# As a workaround, we install ndindex from conda-forge, but this should be fixed somehow
# This has been fixed; see https://github.com/Quansight-Labs/ndindex/issues/156
# conda install -c conda-forge ndindex
python -m pip install -r requirements-runtime.txt
- name: Build
run: |
python setup.py build_ext --inplace
- name: Test
run: |
python -m pip install -r requirements-runtime.txt
python -m pip install -r requirements-tests.txt
python -m pytest
2 changes: 1 addition & 1 deletion .github/workflows/cibuildwheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:

build_wheels:
# Only build wheels when tagging (typically a release)
#if: startsWith(github.event.ref, 'refs/tags')
# if: startsWith(github.event.ref, 'refs/tags')
name: Build wheels on ${{ matrix.os }} for ${{ matrix.arch }} - ${{ matrix.p_ver }}
runs-on: ${{ matrix.os }}
permissions:
Expand Down

0 comments on commit f46c829

Please sign in to comment.