Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try last version 1.14.1 #753

Merged
merged 9 commits into from
May 26, 2023
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
hdf5_version : [ hdf5-1_8_23, hdf5-1_10_9, hdf5-1_12_2, hdf5-1_14_0 ]
hdf5_version : [ hdf5-1_8_23, hdf5-1_10_10, hdf5-1_12_2, hdf5-1_14_1 ]

steps:
- uses: actions/checkout@v3
Expand Down
13 changes: 7 additions & 6 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
fetch-depth: 2
submodules: true

- name: Build and test for code coverage
- name: Build for code coverage
run: |
CMAKE_OPTIONS=(
-GNinja
Expand All @@ -54,11 +54,12 @@ jobs:
-DCMAKE_CXX_FLAGS="-coverage -O0"
)
source $GITHUB_WORKSPACE/.github/build.sh
cd $HIGHFIVE_BUILD
(cd $GITHUB_WORKSPACE; lcov --capture --initial --directory . --no-external --output-file build/coverage-base.info)
cmake --build $HIGHFIVE_BUILD --target test
(cd $GITHUB_WORKSPACE; lcov --capture --directory . --no-external --output-file build/coverage-run.info)
lcov --add-tracefile coverage-base.info --add-tracefile coverage-run.info --output-file coverage-combined.info
- name: Test for code coverage
run: |
lcov --capture --initial --directory . --no-external --output-file build/coverage-base.info
(cd build; cmake --build $HIGHFIVE_BUILD --target test)
lcov --capture --directory . --no-external --output-file build/coverage-run.info
(cd build; lcov --add-tracefile coverage-base.info --add-tracefile coverage-run.info --output-file coverage-combined.info)
- uses: codecov/codecov-action@v3
with:
files: ./build/coverage-combined.info
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/tests_high_five_base.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ TEST_CASE("Test group properties") {
File file(file_name, File::Truncate, fapl);

GroupCreateProps props;
props.add(EstimatedLinkInfo(1000, 500));
props.add(EstimatedLinkInfo(10, 60));
alkino marked this conversation as resolved.
Show resolved Hide resolved
auto group = file.createGroup("g", props);
auto sizes = group.getEstimatedLinkInfo();

Expand Down