add changelog + fix gem version #93
Conversation
CHANGELOG.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| ### master | |||
|
|
|||
| ### 2.0.1 - 2020-03-04 | |||
|
|
|||
| * update vuln gems: bootstrap-sass and nokogiri | |||
There was a problem hiding this comment.
why vuln (which is not obvious what it means if you don't know the context) and not vulnerable if it only takes few more characters? I would stay away from using shortcuts as much as possible.
| @@ -1,3 +1,3 @@ | |||
| module BookingsyncPortal | |||
| VERSION = "1.0.1" | |||
| VERSION = "2.0.1" | |||
There was a problem hiding this comment.
why 2.0.1? this is not a breaking change?
There was a problem hiding this comment.
Well, as you may see on changelog, we agreed to bump gem ver to 2.0.0 on breaking change of dependencies.
### 2.0.0 - 2020-01-20
* [BREAKING CHANGE] update bookingsync_application dependency to be >= 3.0
But seems version was not bumped here at the end.
To keep versioning in right way I have to increase the latest gem version annotated in changelog, i.e. 2.0.0 -> 2.0.1
Makes sense?
There was a problem hiding this comment.
Oh, wow... indeed, definitely makes sense then 👍
|
@Azdaroth , could you please take a look one more time? |
No description provided.