Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add changelog + fix gem version #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add changelog + fix gem version #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e3454a
add changelog + fix gem version
LeonidMorozov Mar 4, 2020
90f14f8
PR feedback
LeonidMorozov Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
### master

### 2.0.1 - 2020-03-04

* update vulnerable gems: bootstrap-sass and nokogiri

### 2.0.0 - 2020-01-20

* [BREAKING CHANGE] update bookingsync_application dependency to be >= 3.0
Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
bookingsync_portal (1.0.1)
bookingsync_portal (2.0.1)
bookingsync_application (>= 3, < 4)
bootstrap-bookingsync-sass (~> 1.0.0)
bootstrap-sass (< 3.5)
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails_5.0.gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: ..
specs:
bookingsync_portal (1.0.1)
bookingsync_portal (2.0.1)
bookingsync_application (>= 3, < 4)
bootstrap-bookingsync-sass (~> 1.0.0)
bootstrap-sass (< 3.5)
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails_5.1.gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: ..
specs:
bookingsync_portal (1.0.1)
bookingsync_portal (2.0.1)
bookingsync_application (>= 3, < 4)
bootstrap-bookingsync-sass (~> 1.0.0)
bootstrap-sass (< 3.5)
Expand Down
2 changes: 1 addition & 1 deletion lib/bookingsync_portal/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module BookingsyncPortal
VERSION = "1.0.1"
VERSION = "2.0.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 2.0.1? this is not a breaking change?

Copy link
Contributor Author

@LeonidMorozov LeonidMorozov Mar 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Azdaroth ,

Well, as you may see on changelog, we agreed to bump gem ver to 2.0.0 on breaking change of dependencies.

### 2.0.0 - 2020-01-20

* [BREAKING CHANGE] update bookingsync_application dependency to be >= 3.0

But seems version was not bumped here at the end.

To keep versioning in right way I have to increase the latest gem version annotated in changelog, i.e. 2.0.0 -> 2.0.1

Makes sense?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, wow... indeed, definitely makes sense then 👍

end