Convert most Buffer usage to Uint8Array

[bjornstar]

As you mentioned in Borewit/token-types#650 a good test is if we can use token-types (& file-type) in music-metadata.

This is not exhaustive, there are still some Buffer usages remaining. However I have all the tests passing which I hope is good enough for a first pass.

I also discovered a race condition with the file-type parsing, we need to wait until the file type is parsed before we add the tags.

This PR depends on changes to:

• uint8array-extras
• strtok3
• token-types
• file-type

[Borewit]

I propose the primary objective (requirement) is to ensure music-metadata can depend on strtok3 and token-type, the "Goodbye Node.js Buffer" versions.

To replace remaining (all) Buffer dependencies in music-metadata is a secondary objective, which can be address in following stage (different PR).

The first objective, I think it is good to do before applying the changes in file-type (as health check as proposed here). The remaining Buffer dependencies in music-metadata should not delay your effort to work towards getting this into file-type.

Only the secondary stage depends on the "Goodbye Node.js Buffer" version of file-type.

[bjornstar]

I propose the primary objective (requirement) is to ensure music-metadata can depend on strtok3 and token-type, the "Goodbye Node.js Buffer" versions.

To replace remaining (all) Buffer dependencies in music-metadata is a secondary objective, which can be address in following stage (different PR).

The first objective, I think it is good to do before applying the changes in file-type (as health check as proposed here). The remaining Buffer dependencies in music-metadata should not delay your effort to work towards getting this into file-type.

Only the secondary stage depends on the "Goodbye Node.js Buffer" version of file-type.

I agree, we don't need to replace all the Buffer usage in the first pass. I think file-type can go first, but it should probably work in either order.

Once the shared dependencies are released it should be clear that file-type and music-metadata both work with the new versions.

[Borewit]

Can you have a look to the remaining test cases, why these are failing?

[Borewit]

I managed to music-metadata pass all unit tests 💯✅, combining all outstanding PR's:

• strtok3
• token-types
• file-type (after fixing sindresorhus/file-type@4caaee2)
• this one: music-metadata

[bjornstar]

Appveyor is failing because uint8array-extras specifies node 18 as the minimum node version.

I added a fix for it in #2105

[bjornstar]

@Borewit This needs a new release of strtok3 that includes Borewit/strtok3#1074

[coveralls]

coverage: 96.524% (-0.001%) from 96.525%
when pulling 9f7b8d1 on bjornstar:goodbye-nodejs-buffer
into 24a507e on Borewit:master.

[coveralls]

coverage: 96.524% (-0.001%) from 96.525%
when pulling a7a45ff on bjornstar:goodbye-nodejs-buffer
into 24a507e on Borewit:master.

[coveralls]

coverage: 96.523% (-0.002%) from 96.525%
when pulling 4503c55 on bjornstar:goodbye-nodejs-buffer
into 24a507e on Borewit:master.

[bjornstar]

All dependencies have been updated, this should be good to go.

[coveralls]

coverage: 96.514% (-0.01%) from 96.525%
when pulling e767904 on bjornstar:goodbye-nodejs-buffer
into 24a507e on Borewit:master.

[Borewit]

All dependencies have been updated, this should be good to go.

Sorry for not being more responsive, my time is limited and I first objective is to finalize sindresorhus/file-type#635, aiming release no Node.js dependent for file-type using the primary (non Node) entry point.

[coveralls]

coverage: 96.514% (-0.01%) from 96.525%
when pulling cda25d5 on bjornstar:goodbye-nodejs-buffer
into 06d9425 on Borewit:master.

[Borewit]

Thanks a lot for your commitment and hard work @bjornstar !

[Borewit]

Part of v9.0.0