-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add getUintBE, findSequence, and encoding for uint8ArrayToString #12
feat: add getUintBE, findSequence, and encoding for uint8ArrayToString #12
Conversation
I believe this one is ready to go and once we get a release we can move forward with: In that order. |
You need to update the readme too. |
Explained in more detail here, I propose this steps:
|
Since |
@bjornstar I noticed two issues in the
|
|
There is some functionality from
Buffer
that was being used byfile-type
that seems to be generally useful, specificallygetUintBE
and the behavior ofindexOf
to take a buffer instead of a single byte's worth of an integer.It would be great to get this in and released so it can be used in sindresorhus/file-type#633