Merge pull request #80 from BottleRocketStudios/feature/cleanupTODOs

Cleaned up some TODOs

CHANGELOG.md

@@ -5,10 +5,15 @@
 * Remove the type definitions deprecated in 3.0.0
 [Will McGinty](https://github.com/wmcginty)
 [#77](https://github.com/BottleRocketStudios/iOS-Hyperspace/pull/77)
+
 * Rename `dataTransformer` family of functions to  `successTransformer` to more accurately reflect their purpose.
 [Will McGinty](https://github.com/wmcginty)
 [#78](https://github.com/BottleRocketStudios/iOS-Hyperspace/pull/78)
 
+* Cleaned up some TODOs in the code.
+[Tyler Milner](https://github.com/tylermilner)
+[#80](https://github.com/BottleRocketStudios/iOS-Hyperspace/pull/80)
+
 ##### Bug Fixes
 
 * None.

Sources/Hyperspace/HTTP/HTTP.swift

@@ -6,12 +6,6 @@
 //  Copyright © 2017 Bottle Rocket Studios. All rights reserved.
 //
 
-//
-//  TODO: Future functionality:
-//          - Are there any HTTP.HeaderKeys that we should add (or remove)?
-//          - Are there any HTTP.HeaderValues that we should add (or remove)?
-//
-
 import Foundation
 
 // swiftlint:disable nesting

Sources/Hyperspace/Request/Request.swift

@@ -6,11 +6,6 @@
 //  Copyright © 2017 Bottle Rocket Studios. All rights reserved.
 //
 
-//
-//  TODO: Future functionality:
-//          - Extend to allow for easy handling of multipart form data upload.
-//
-
 import Foundation
 import Result
 

Tests/Helper/Mocks/MockBackendService.swift

@@ -44,7 +44,6 @@ extension MockBackendServiceError: Equatable {
         case (.networkError(let lhsError, let lhsResponse), .networkError(let rhsError, let rhsResponse)):
             return lhsError == rhsError && lhsResponse == rhsResponse
         case (.dataTransformationError(let lhsError), .dataTransformationError(let rhsError)):
-            // TODO: Need to come up with a better way to compare equality in this case
             return lhsError.localizedDescription == rhsError.localizedDescription
         default:
             return false

Tests/URLQueryParameterTests.swift

@@ -18,7 +18,6 @@ class URLQueryParameterTests: XCTestCase {
             URLQueryItem(name: "param1", value: "param1value"),
             URLQueryItem(name: "param2", value: "param2 value"),
             URLQueryItem(name: "param3", value: nil)
-            // TODO: What other complex query parameters can we generate to test the URL encoding?
         ]
 
         let finalURL = url.appendingQueryItems(queryParameters)