Cleaned up some TODOs #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…haven't added many. Any additions can be made in PRs.
…ty as an equality check for MockBackendServiceError. Since this is code used for the unit tests, I think it's probably fine.
…. It's been a year and I don't think we've seen any bugs. We can add more test cases as necessary in the future.
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=========================================
- Coverage 95.61% 95.6% -0.01%
=========================================
Files 35 35
Lines 1026 1024 -2
=========================================
- Hits 981 979 -2
Misses 45 45
Continue to review full report at Codecov.
|
wmcginty
approved these changes
Jan 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.