Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned up some TODOs #80

Merged
merged 5 commits into from
Jan 5, 2019
Merged

Cleaned up some TODOs #80

merged 5 commits into from
Jan 5, 2019

Commits on Jan 4, 2019

  1. Removed TODO for request header keys/values. It's been a year and we … 

    …haven't added many. Any additions can be made in PRs.
    @br-tyler-milner
    br-tyler-milner committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    392ce6a View commit details
    Browse the repository at this point in the history

  2. Removed multipart form TODO. The feature is being tracked on GitHub - #… 

    …58.
    @br-tyler-milner
    br-tyler-milner committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    7e71fd6 View commit details
    Browse the repository at this point in the history

  3. Removed TODO dealing with using Error's 'localizedDescription' proper… 

    …ty as an equality check for MockBackendServiceError. Since this is code used for the unit tests, I think it's probably fine.
    @br-tyler-milner
    br-tyler-milner committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    ecad833 View commit details
    Browse the repository at this point in the history

  4. Removed TODO about adding query parameter URL encoding test scenarios… 

    …. It's been a year and I don't think we've seen any bugs. We can add more test cases as necessary in the future.
    @br-tyler-milner
    br-tyler-milner committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    871d4d2 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2019

  1. Added CHANGELOG entry.

    @br-tyler-milner
    br-tyler-milner committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    467d2ea View commit details
    Browse the repository at this point in the history