Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

none: some env tidy-up #35

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

Shane-XB-Qian
Copy link
Contributor

  1. Makefile: local may have 'DB2_HOME' already
  2. .gitignore: adding ignores for vim and tags

1. Makefile: local may have 'DB2_HOME' already
2. .gitignore: adding ignores for vim and tags

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
export GO15VENDOREXPERIMENT=1
export GO111MODULE=on
export CGO_CFLAGS=-I${DB2HOME}/include
export CGO_LDFLAGS=-L${DB2HOME}/lib
export LD_LIBRARY_PATH=${DB2HOME}/lib
Copy link
Owner

@Breeze0806 Breeze0806 Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that DB2_HOME exists, I'm concerned about whether we can still compile successfully with the missing "export LD_LIBRARY_PATH=${DB2HOME}/lib" in this context.

@Shane-XB-Qian
Copy link
Contributor Author

Shane-XB-Qian commented Apr 10, 2024 via email

@Breeze0806
Copy link
Owner

export GO15VENDOREXPERIMENT=1 export GO111MODULE=on export CGO_CFLAGS=-I${DB2HOME}/include export CGO_LDFLAGS=-L${DB2HOME}/lib -export LD_LIBRARY_PATH=${DB2HOME}/lib Given that DB2_HOME exists, I'm concerned about whether we can still compile successfully with the missing "export LD_LIBRARY_PATH=${DB2HOME}/lib" in this context.
yes, if DB2_HOME there, then LD_LIBRARY_PATH should be configured already, you donnot need to rely on third party driver if so.

-- shane.xb.qian

In your environment, it may be the case that setting DB2_HOME alone is insufficient to ensure that LD_LIBRARY_PATH is configured correctly, which could potentially lead to compilation failures for others.

@Breeze0806
Copy link
Owner

I'm not sure if this is correct. I need to verify it on the weekend.

@Shane-XB-Qian
Copy link
Contributor Author

Shane-XB-Qian commented Apr 10, 2024 via email

@Shane-XB-Qian
Copy link
Contributor Author

Shane-XB-Qian commented Apr 10, 2024 via email

@Breeze0806
Copy link
Owner

export GO15VENDOREXPERIMENT=1 export GO111MODULE=on export CGO_CFLAGS=-I${DB2HOME}/include export CGO_LDFLAGS=-L${DB2HOME}/lib -export LD_LIBRARY_PATH=${DB2HOME}/lib Given that DB2_HOME exists, I'm concerned about whether we can still compile successfully with the missing "export LD_LIBRARY_PATH=${DB2HOME}/lib" in this context. > yes, if DB2_HOME there, then LD_LIBRARY_PATH should be configured already, you donnot need to rely on third party driver if so. > > -- shane.xb.qian In your environment, it may be the case that setting DB2_HOME alone is insufficient to ensure that LD_LIBRARY_PATH is configured correctly, which could potentially lead to compilation failures for others.
no, these are the standard env of db2 itself, which compared to you self configured DB2HOME, // and actually the standard LD_LIBRARY_PATH of db2 was not only xxx/lib, but also others libs, but just maybe not relevant to this code base.

-- shane.xb.qian

Ok, I'm not very proficient in DB2. Currently, I'm referencing the configuration at https://github.com/ibmdb/go_ibm_db/tree/v0.4.4. When you mentioned the standard environmental configuration for DB2, do you mean the configuration on the DB2 database server or on the DB2 client server?

@Shane-XB-Qian
Copy link
Contributor Author

Shane-XB-Qian commented Apr 10, 2024 via email

@Breeze0806
Copy link
Owner

I'm not sure if this is correct. I need to verify it on the weekend.
sure, take your time, // btw: i guess you were working for one of xxcloud in cn? ahahaha... // i am playing db2 many years... 😄

-- shane.xb.qian

Are you an experienced user of DB2? That's excellent. I might learn a lot from you. I checked out your profile and found out that you're also from China.

@Breeze0806
Copy link
Owner

Ok, I'm not very proficient in DB2. Currently, I'm referencing the configuration at https://github.com/ibmdb/go_ibm_db/tree/v0.4.4. When you mentioned the standard environmental configuration for DB2, do you mean the configuration on the DB2 database server or on the DB2 client server?
nevermind this, the 'ifdef' of this change was just a safeguard, and make the dev env of db2 be easy // i saw your doc said lots additions about db2, but actually it can be easy, // anyway, your original DB2HOME was there still, it can continue to work.

-- shane.xb.qian

Oh, I will try it this weekend.

@Shane-XB-Qian
Copy link
Contributor Author

Shane-XB-Qian commented Apr 10, 2024 via email

@Breeze0806 Breeze0806 merged commit d428444 into Breeze0806:main Apr 14, 2024
6 checks passed
@Shane-XB-Qian Shane-XB-Qian deleted the none_some_env_tidyup branch April 14, 2024 13:56
Breeze0806 added a commit that referenced this pull request Jul 21, 2024
* none: some env tidy up (#35)

1. Makefile: local may have 'DB2_HOME' already
2. .gitignore: adding ignores for vim and tags

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>

* fix: fix split bug when setting is not set (#37)

* feat & fix & docs: Add column name to error message when there's an error in reading or writing a column, fix the issue where ignoreOneByOneError does not work when set to false, and add F&Q for the database reader and writer. (#38)

* none: some tiny code tidy-up (#34)

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>

* docs: Update README.md

* feat & docs: improve go1.16 to go 1.20, change package sqlserver to github.com/microsoft/go-mssqldb,and Update all packages to the latest version.

* fix: fix some complime error

* fix:fix complie error

* scripts: do lint for all go version

* fix: 修复mysql的问题

* docs: fix go version

* feat: in package element add NewBigIntColumnValueFromUint64 and NewDecimalColumnValueFromFloat32, remove Float64 and add Uint64.

---------

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Co-authored-by: Shane-XB-Qian <shane.qian@live.com>
Co-authored-by: 励码万言 <48382427+limawanyan@users.noreply.github.com>
Breeze0806 added a commit that referenced this pull request Sep 28, 2024
* none: some env tidy up (#35)

1. Makefile: local may have 'DB2_HOME' already
2. .gitignore: adding ignores for vim and tags

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>

* fix: fix split bug when setting is not set (#37)

* feat:add sqlite3

* feat:add sqlite3

* feat:add sqlite3

* feat:sqlite3

* feat:improve sqlite3

* feat:sqlite3

* feat:add sqlite3 test

* feat:sqlite3

* feat:add sqlite3 test

* feat:add sqlite3 test

---------

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Co-authored-by: Shane-XB-Qian <shane.qian@live.com>
Co-authored-by: Breeze0806 <53822089+Breeze0806@users.noreply.github.com>
limawanyan added a commit that referenced this pull request Sep 28, 2024
* feat:  add database sqlite3 reader/writer

* sqlite3: reset (#43)

* none: some env tidy up (#35)

1. Makefile: local may have 'DB2_HOME' already
2. .gitignore: adding ignores for vim and tags

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>

* fix: fix split bug when setting is not set (#37)

* feat & fix & docs: Add column name to error message when there's an error in reading or writing a column, fix the issue where ignoreOneByOneError does not work when set to false, and add F&Q for the database reader and writer. (#38)

* none: some tiny code tidy-up (#34)

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>

* docs: Update README.md

* feat & docs: improve go1.16 to go 1.20, change package sqlserver to github.com/microsoft/go-mssqldb,and Update all packages to the latest version.

* fix: fix some complime error

* fix:fix complie error

* scripts: do lint for all go version

* fix: 修复mysql的问题

* docs: fix go version

* feat: in package element add NewBigIntColumnValueFromUint64 and NewDecimalColumnValueFromFloat32, remove Float64 and add Uint64.

---------

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Co-authored-by: Shane-XB-Qian <shane.qian@live.com>
Co-authored-by: 励码万言 <48382427+limawanyan@users.noreply.github.com>

* feat: add sqlite3 data read

* add Sqlite3 (#52)

* none: some env tidy up (#35)

1. Makefile: local may have 'DB2_HOME' already
2. .gitignore: adding ignores for vim and tags

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>

* fix: fix split bug when setting is not set (#37)

* feat:add sqlite3

---------

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Co-authored-by: Shane-XB-Qian <shane.qian@live.com>
Co-authored-by: Breeze0806 <53822089+Breeze0806@users.noreply.github.com>

* fix: 修复sqlite3测试的问题

* fix: fit go1.20

* fix: makefile

---------

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Co-authored-by: Shane-XB-Qian <shane.qian@live.com>
Co-authored-by: 励码万言 <48382427+limawanyan@users.noreply.github.com>
limawanyan added a commit that referenced this pull request Oct 8, 2024
…y in sql server (#54)

* add Sqlite3 to v0.2.x (#53)

* feat:  add database sqlite3 reader/writer

* sqlite3: reset (#43)

* none: some env tidy up (#35)

1. Makefile: local may have 'DB2_HOME' already
2. .gitignore: adding ignores for vim and tags

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>

* fix: fix split bug when setting is not set (#37)

* feat & fix & docs: Add column name to error message when there's an error in reading or writing a column, fix the issue where ignoreOneByOneError does not work when set to false, and add F&Q for the database reader and writer. (#38)

* none: some tiny code tidy-up (#34)

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>

* docs: Update README.md

* feat & docs: improve go1.16 to go 1.20, change package sqlserver to github.com/microsoft/go-mssqldb,and Update all packages to the latest version.

* fix: fix some complime error

* fix:fix complie error

* scripts: do lint for all go version

* fix: 修复mysql的问题

* docs: fix go version

* feat: in package element add NewBigIntColumnValueFromUint64 and NewDecimalColumnValueFromFloat32, remove Float64 and add Uint64.

---------

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Co-authored-by: Shane-XB-Qian <shane.qian@live.com>
Co-authored-by: 励码万言 <48382427+limawanyan@users.noreply.github.com>

* feat: add sqlite3 data read

* add Sqlite3 (#52)

* none: some env tidy up (#35)

1. Makefile: local may have 'DB2_HOME' already
2. .gitignore: adding ignores for vim and tags

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>

* fix: fix split bug when setting is not set (#37)

* feat:add sqlite3

---------

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Co-authored-by: Shane-XB-Qian <shane.qian@live.com>
Co-authored-by: Breeze0806 <53822089+Breeze0806@users.noreply.github.com>

* fix: 修复sqlite3测试问题

* fix: fit go1.20

* fix: makefile

---------

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Co-authored-by: Shane-XB-Qian <shane.qian@live.com>
Co-authored-by: 励码万言 <48382427+limawanyan@users.noreply.github.com>

* docs & test: add sqlite3 unit test , fix the issue of readme document

* fix: fix check error

* docs: add docment of bulk copy(BULK INSERT)

* build: upgrade mod file

* docs: fix some errors in config file and document

---------

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Co-authored-by: Shane-XB-Qian <shane.qian@live.com>
Co-authored-by: 励码万言 <48382427+limawanyan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants