Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

none: some env tidy-up #35

Merged
merged 1 commit into from
Apr 14, 2024
Merged

none: some env tidy-up #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,7 @@ release/*
*.zip
*.tar.gz
*.chn
*.en
*.en

*.swp
tags
10 changes: 7 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
DB2HOME=${GOPATH}/src/github.com/ibmdb/clidriver
ifdef DB2_HOME
DB2HOME=${DB2_HOME}
else
DB2HOME=${GOPATH}/src/github.com/ibmdb/clidriver
export LD_LIBRARY_PATH=${DB2HOME}/lib
endif
export GO15VENDOREXPERIMENT=1
export GO111MODULE=on
export CGO_CFLAGS=-I${DB2HOME}/include
export CGO_LDFLAGS=-L${DB2HOME}/lib
export LD_LIBRARY_PATH=${DB2HOME}/lib
# Many Go tools take file globs or directories as arguments instead of packages.
Copy link
Owner

@Breeze0806 Breeze0806 Apr 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that DB2_HOME exists, I'm concerned about whether we can still compile successfully with the missing "export LD_LIBRARY_PATH=${DB2HOME}/lib" in this context.

# The linting tools evolve with each Go version, so run them only on the latest
# stable release.
Expand Down Expand Up @@ -63,4 +67,4 @@ release:
@go run tools/datax/release/main.go
.PHONY: doc
doc:
@godoc -http=:6080
@godoc -http=:6080
Loading