Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBA_fnc_canAddItem for vehicles and crates #1528

Merged
merged 2 commits into from
Mar 19, 2022
Merged

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Nov 27, 2021

When merged this pull request will:

  • make CBA_fnc_canAddItem work on vehicles and crates.
  • use HashMap for item mass cache instead of pseudo namespace.

This requires 2.08 to work (maxLoad, load reporting anything != 0 for non person objects).

@LinkIsGrim
Copy link
Contributor

Why not check against maxLoad of uniformContainer, etc. as well? Esp. since they can be edited through scripting in 2.08.

@commy2
Copy link
Contributor Author

commy2 commented Feb 18, 2022

PR was written to work with 2.06

@LinkIsGrim
Copy link
Contributor

Am I misreading "this requires 2.08 to work"?

@commy2
Copy link
Contributor Author

commy2 commented Feb 19, 2022

Then idk what feature you're talking about.

Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take into account new setMaxLoad functionality from 2.08 with this.

addons/common/fnc_canAddItem.sqf Outdated Show resolved Hide resolved
addons/common/fnc_canAddItem.sqf Outdated Show resolved Hide resolved
addons/common/fnc_canAddItem.sqf Outdated Show resolved Hide resolved
@Drofseh
Copy link
Contributor

Drofseh commented Mar 8, 2022

I suggest accepting Salluci's suggestions and then this can be merged now that 2.08 is out.

Then #1527 can also be merged

Support 2.08's `setMaxLoad`

Co-authored-by: GhostIsSpooky <69561145+Salluci@users.noreply.github.com>
@PabstMirror PabstMirror added this to the 3.15.7 milestone Mar 19, 2022
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working

@PabstMirror PabstMirror merged commit 3199775 into master Mar 19, 2022
@PabstMirror PabstMirror deleted the canAddItem-for-vehicles branch March 19, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants