Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translation, part 1 #979

Merged
merged 2 commits into from
Sep 17, 2018
Merged

German translation, part 1 #979

merged 2 commits into from
Sep 17, 2018

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Sep 13, 2018

When merged this pull request will:

  • adds German translations
  • removes one original, which we never make use of anywhere else
  • fixd English spelling

@@ -3,6 +3,7 @@
<Package name="Common">
<Key ID="STR_CBA_Common_Component">
<English>Community Base Addons - Common Component</English>
<German>Community Base Addons - Gemeinsame Komponente</German>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auch: Allgemeine Komponente

Copy link
Contributor Author

@commy2 commy2 Sep 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always understood this to be the "shared component" - stuff that is used in multiple places. That is at least how we treated it in ACE: stuff that is used in at least two places gets moved to ACE Common. Although I realize that not everything in CBA Common or ACE Common is shared between two other components or even used by a single other one.

I would've used "Allgemeine Komponente" if it were named "CBA General" instead of "CBA Common".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea from this perspective you convinced me. Good job. Go into politics! 📦

@@ -12,6 +13,7 @@
</Key>
<Key ID="STR_CBA_accessory_railNext">
<English>Next rail item state</English>
<German>Nächster Zustand Schienenaufsatz</German>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could "Modus" be used here? Or atleast "Nächster Schienenaufsatz Zustant"?
This sounds very weird.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STR_CBA_accessory_railNext_tooltip also uses "Modus"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 für mode/Modus.
Unabhängig davon: entweder "Zustand des Aufsatzes" oder "Aufsatzzustand". Nix mit Leerzeichen.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for "Modus"

Copy link
Contributor Author

@commy2 commy2 Sep 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STR_CBA_accessory_railNext_tooltip also uses "Modus"

ENG uses "state" in STR_CBA_accessory_railNext and "mode" in STR_CBA_accessory_railNext_tooltip.
state - Zustand, mode - Modus.

@@ -48,6 +53,7 @@
</Key>
<Key ID="STR_CBA_accessory_opticNext">
<English>Next optics state</English>
<German>Nächster Zustand Optik</German>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again the "Modus" talk. STR_CBA_accessory_opticNext_tooltip uses modus.

This was referenced Sep 14, 2018
@commy2 commy2 merged commit a3da998 into master Sep 17, 2018
@commy2 commy2 deleted the german-translations branch September 17, 2018 08:49
ViperMaul added a commit that referenced this pull request Sep 19, 2018
* master:
  Add Feature Camera Player EH (#982)
  German brands for JR and JAM components (#988)
  veteran29 Polish translation updates master (#986)
  German translation, part 3 (#981)
  German translation, part 2 (#980)
  German translation, part 1 (#979)
  add Joint Ammo Magazines A3 (#928)
  CBA_fnc_getVolume not calculating volume correctly (#984)
  ProjectileTracking - Stop tracking stationary objects (#985)
@commy2 commy2 added this to the 3.9 milestone Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants