-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
German translation, part 2 #980
Conversation
@@ -3,6 +3,7 @@ | |||
<Package name="XEH"> | |||
<Key ID="STR_CBA_XEH_Component"> | |||
<English>Community Base Addons - Extended Event Handlers</English> | |||
<German>Community Base Addons - Erweiterte Ereignishandler</German> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ereignisbehandlung
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently it's a toss up: https://www.dict.cc/english-german/event+handler.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't translate this at all since it's a code thing. You didn't translate strings to "Zeichenketten" either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auch die Ereignisbehandlungsroutinen (englisch event handler, deutsch Ereignishandler) und die Ereignisse selbst werden dann als Objekte modelliert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when you want to keep it then please also translate String to "Zeichenketten"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ done
addons/main/stringtable.xml
Outdated
@@ -14,6 +14,7 @@ | |||
</Key> | |||
<Key ID="STR_CBA_URL"> | |||
<English>https://www.github.com/CBATeam/CBA_A3</English> | |||
<German>https://www.github.com/CBATeam/CBA_A3</German> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just simply use a single entry here as every entry is literally the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a string so it can be changed if needed everywhere at once, while not having to use a macro which would have character escaping issues. It is translated I guess mainly so Jonpas' translation counter bot says 100% eventually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flummi's bot. ;)
But yes.
Best to just throw that under all supported languages, so bot picks them all up and counts them.
addons/settings/stringtable.xml
Outdated
@@ -3,6 +3,7 @@ | |||
<Package name="Settings"> | |||
<Key ID="STR_cba_settings_Component"> | |||
<English>Community Base Addons - Settings Component</English> | |||
<German>Community Base Addons - Einstellungskomponente</German> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This says component. But music/network/strings/UI/Vectors/Versioning just don't.
Community Base Addons - Einstellungen
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this more. Should I change it in English as well?
Fixed some missing apostrophes in English while editing the file. I at least think those should be placed there. |
* master: Add Feature Camera Player EH (#982) German brands for JR and JAM components (#988) veteran29 Polish translation updates master (#986) German translation, part 3 (#981) German translation, part 2 (#980) German translation, part 1 (#979) add Joint Ammo Magazines A3 (#928) CBA_fnc_getVolume not calculating volume correctly (#984) ProjectileTracking - Stop tracking stationary objects (#985)
When merged this pull request will: