Skip to content

Commit

Permalink
Remove support for Python 3.8 (#1253)
Browse files Browse the repository at this point in the history
* Fixing PyQt5-sip to the last version for python 3.8

* Removing tests and documentation for python 3.8

* Removing and ignoring some accidentally added files

* Nightlies use 3.12, remove unneeded restrictions on >3.8 and <3.8
  • Loading branch information
ksbeattie authored Dec 14, 2024
1 parent 62534b8 commit 8fb9a8f
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 15 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ jobs:
fail-fast: false
matrix:
python-version:
- '3.8'
- '3.9'
- '3.10'
- '3.11'
Expand Down Expand Up @@ -167,7 +166,6 @@ jobs:
fail-fast: false
matrix:
python-version:
- '3.8'
- '3.9'
- '3.10'
- '3.11'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/nightlies.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ jobs:
fail-fast: false
matrix:
python-version:
- '3.8'
- '3.9'
- '3.12'
os:
- linux
- win64
Expand All @@ -47,7 +47,7 @@ jobs:
pip-install-target: https://github.com/CCSI-Toolset/FOQUS/archive/master.zip
- foqus-install-target: stable
os: win64
python-version: '3.8'
python-version: '3.9'

steps:
- name: Set up Conda
Expand Down
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,6 @@ gams
logging.conf
logs
turbine.cfg
user_plugins
user_plugins
turbine_aws.cfg
user_ml_ai_models/__init__.py
4 changes: 2 additions & 2 deletions docs/source/chapt_install/install_python.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
Install Python
--------------

Python version 3.8 up through 3.12 is required to run FOQUS.
Python version 3.9 up through 3.12 is required to run FOQUS.

We recommend using either the `Miniconda <https://docs.conda.io/en/latest/miniconda.html>`_ or
`Anaconda <https://www.anaconda.com/download/>`_ Python distribution and package management
Expand All @@ -17,7 +17,7 @@ ability to create self-contained python environments without any need for admini
privileges. These separate environments can have different set of packages, isolating version
dependencies when working with multiple python projects.

If you have a working version of Python 3.8 through 3.12, which you prefer over Anaconda, you can
If you have a working version of Python 3.9 through 3.12, which you prefer over Anaconda, you can
skip these steps.

Anaconda or Miniconda Install and Setup
Expand Down
10 changes: 2 additions & 8 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,8 @@
# - also pinning the version for Astroid (used by pylint to analyze the AST)
# since there can be significant differences between (non-major) versions,
# both in terms of behavior and performance
# - we need to use Pylint 2 with Python 3.8 b/c of a critical error (stack overflow)
# occurring with Pylint 3
pylint==2.17.7;python_version=="3.8"
astroid==2.15.8;python_version=="3.8"
pylint==3.1.0;python_version>"3.8"
astroid==3.1.0;python_version>"3.8"
pylint==3.1.0
astroid==3.1.0

pytest<8.1
### coverage
Expand All @@ -24,8 +20,6 @@ addheader==0.3.2
pytest-qt==4.2.*
python-slugify
oyaml
# singledispatchmethod needed for < 3.8
singledispatchmethod;python_version<"3.8"
hypothesis

sphinx
Expand Down

0 comments on commit 8fb9a8f

Please sign in to comment.