-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for Python 3.8 #1253
Conversation
Things I noticed while doing this:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1253 +/- ##
=======================================
Coverage 38.47% 38.47%
=======================================
Files 164 164
Lines 37020 37020
Branches 5728 5728
=======================================
Hits 14243 14243
Misses 21650 21650
Partials 1127 1127 ☔ View full report in Codecov by Sentry. |
After e11d490 which just fixed the version of PyQt5-sip to 12.15.0 for python 3.8, all tests passed. |
.github/workflows/nightlies.yml
Outdated
- '3.9' | ||
- '3.10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make sense to set these to 3.12
, so that the oldest and newest Python version are both tested
requirements-dev.txt
Outdated
pylint==3.1.0;python_version>"3.8" | ||
astroid==3.1.0;python_version>"3.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make sense to remove the python_version>3.8
, since that's now always going to be true.
pylint==3.1.0;python_version>"3.8" | |
astroid==3.1.0;python_version>"3.8" | |
pylint==3.1.0 | |
astroid==3.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a quick look (i.e. only looking at the changes in this PR, and not through the entire codebase), things look fine apart from a couple minor suggestions.
user_plugins | ||
turbine_aws.cfg | ||
user_ml_ai_models/__init__.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this added here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I accidentally added them in fa2d5b0 ! I figured I (or others) might make the same mistake again so I added them to be ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Fixes/Addresses:
PyQt5-sip was just updated to 12.16.0 which removed support for Python 3.8. This is now breaking the CI for PR #1252 in an entirely unrelated way.
Summary/Motivation:
Since Python 3.8 is now EOL, we should remove support for it as well.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: