-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDoE: Implementing previous data into IRSF #1096
Conversation
@mirandamartin Can you provide us with a write-up of the algorithm details so that we can confirm that the changes we made are valid? |
…n top, updating scatter and histogram legend labels
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1096 +/- ##
==========================================
- Coverage 34.95% 34.76% -0.19%
==========================================
Files 161 161
Lines 36432 36296 -136
Branches 5953 5940 -13
==========================================
- Hits 12734 12618 -116
+ Misses 22715 22696 -19
+ Partials 983 982 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…ePreview wasn't correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Designs created during testing look good to me. And the runtime is significantly improved. Thanks for all the hard work!
Fixes/Addresses:
Addresses issue #1077
Summary/Motivation:
In the SDoE module, IRSF designs where already implemented but they weren't accepting previous data files. Now IRSF is also able to handle previous data file like USF and NUSF.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: