Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDoE: Implementing previous data into IRSF #1096

Merged
merged 40 commits into from
Mar 21, 2023

Conversation

sotorrio1
Copy link
Member

Fixes/Addresses:

Addresses issue #1077

Summary/Motivation:

In the SDoE module, IRSF designs where already implemented but they weren't accepting previous data files. Now IRSF is also able to handle previous data file like USF and NUSF.

Changes proposed in this PR:

  • adding previous data file to required functions in irsf.py
  • adapting the IRSF plotting to show previous data points (plot_utils.py)
  • refactoring in nusf.py and irsf.py to reduce repetitive code

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@pn51
Copy link
Contributor

pn51 commented Dec 29, 2022

@mirandamartin Can you provide us with a write-up of the algorithm details so that we can confirm that the changes we made are valid?

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Patch coverage: 80.19% and project coverage change: -0.19 ⚠️

Comparison is base (d625542) 34.95% compared to head (467042b) 34.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1096      +/-   ##
==========================================
- Coverage   34.95%   34.76%   -0.19%     
==========================================
  Files         161      161              
  Lines       36432    36296     -136     
  Branches     5953     5940      -13     
==========================================
- Hits        12734    12618     -116     
+ Misses      22715    22696      -19     
+ Partials      983      982       -1     
Impacted Files Coverage Δ
foqus_lib/gui/sdoe/sdoeAnalysisDialog.py 0.00% <0.00%> (ø)
foqus_lib/gui/sdoe/sdoeSimSetup.py 9.53% <ø> (ø)
foqus_lib/framework/sdoe/plot_utils.py 7.62% <10.00%> (-0.07%) ⬇️
foqus_lib/framework/sdoe/irsf.py 86.36% <85.71%> (+1.47%) ⬆️
foqus_lib/framework/sdoe/distance.py 94.11% <100.00%> (+1.52%) ⬆️
foqus_lib/framework/sdoe/nusf.py 84.27% <100.00%> (-0.58%) ⬇️
foqus_lib/framework/sdoe/sdoe.py 55.55% <100.00%> (+0.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@mirandamartin mirandamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Designs created during testing look good to me. And the runtime is significantly improved. Thanks for all the hard work!

@ksbeattie ksbeattie merged commit 36d213b into CCSI-Toolset:master Mar 21, 2023
@sotorrio1 sotorrio1 deleted the issue-1077 branch March 21, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR SDoE Sequential Design of Experiments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDOE Generate Candidate Set - preview samples error SDoE: Adding previous data to IRSF
4 participants