Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update add_rr_data_to_eicr to check if RR data is already present #844

Closed
emmastephenson opened this issue Sep 29, 2023 · 0 comments · Fixed by #866 or #870
Closed

Update add_rr_data_to_eicr to check if RR data is already present #844

emmastephenson opened this issue Sep 29, 2023 · 0 comments · Fixed by #866 or #870
Assignees
Labels
Streamline eCR Issues for Streamline eCR team to work on tech debt Technical debt related work

Comments

@emmastephenson
Copy link
Collaborator

Action Requested

The RR extraction function add_rr_data_to_eicr needs to see if RR data has already been added to the eICR before it attempts to merge the fields.

Acceptance Criteria

If an eICR with RR data already combined into it and an RR are passed to the add_rr_data_to_eicr function, an exception is thrown. The exception should also be handled in the validation and FHIR conversion containers.

Additional Information

See this PR thread for context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Streamline eCR Issues for Streamline eCR team to work on tech debt Technical debt related work
Projects
None yet
1 participant