Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for RR field presence before merging RR to eCR #866

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

emmastephenson
Copy link
Collaborator

PULL REQUEST

Summary

Checks to see if RR data has already been extracted and inserted into the eCR before merging RR data into eCR. (Basically - have we already called this method?)

Related Issue

Fixes #844

Additional Information

Debated for a bit about raising a ValueError instead of just returning the eCR values, but this seemed cleaner - there's no need for the caller to know they called the method with a pre-merged eICR.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #866 (6e79e0e) into main (397f6e8) will decrease coverage by 0.04%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
- Coverage   96.40%   96.37%   -0.04%     
==========================================
  Files          46       46              
  Lines        2645     2648       +3     
==========================================
+ Hits         2550     2552       +2     
- Misses         95       96       +1     
Flag Coverage Δ
unit-tests 96.37% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
phdi/fhir/conversion/convert.py 99.12% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@BradySkylight BradySkylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, but it may be better to search for the specific code ("2.16.840.1.113883.6.1"), rather than looking for text. But, either way, it should technically work.

Copy link
Contributor

@BradySkylight BradySkylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@emmastephenson emmastephenson merged commit 8a090df into main Oct 17, 2023
20 checks passed
@emmastephenson emmastephenson deleted the emma/844-rr-check branch October 17, 2023 21:32
emmastephenson added a commit that referenced this pull request Oct 17, 2023
emmastephenson added a commit that referenced this pull request Oct 17, 2023
Revert "Check for RR field presence before merging RR to eCR (#866)"

This reverts commit 8a090df.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update add_rr_data_to_eicr to check if RR data is already present
2 participants