Check that RR isn't already present before attempting to merge with eICR #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #870 +/- ##
=======================================
Coverage 96.37% 96.37%
=======================================
Files 46 46
Lines 2645 2648 +3
=======================================
+ Hits 2549 2552 +3
Misses 96 96
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Checks to see if RR data has already been extracted and inserted into the eCR before merging RR data into eCR.
Related Issue
Fixes #844
Additional Information
The original PR (#866) checked for the value
2.16.840.1.113883.6.1, which turns out to be the unique ID for the LOINC system as a whole 😅 This updated branch instead checks for the specific RR code, 88085-6. Integration tests caught this once it was merged tomain, because they were using more robust sample eICR/RR files - those eICRs already had LOINC codes elsewhere for other fields, so failed to merge the eICRs and thus failed the tests. Going to spend a little time looking into importing the "current" version of the SDK for integration tests, so we don't just catch it after merge tomain, but that's for a different PR!Note - I manually checked the integration tests (installing
phdi@current commit) and they do work with this version.Checklist