Replace FastAPI class with PHDI BaseService for container apps #520
Conversation
…discuss naming convention later
…ase image is from Microsoft
…ined custom health check
robertmitchellv
requested review from
nickbristow,
nickclyde,
bamader,
m-goggins,
emmastephenson,
gordonfarrell,
DanPaseltiner,
KennethSkylight and
BradySkylight
|
Still working on |
Codecov Report
@@ Coverage Diff @@
## main #520 +/- ##
=======================================
Coverage 96.49% 96.49%
=======================================
Files 45 45
Lines 2479 2479
=======================================
Hits 2392 2392
Misses 87 87
Flags with carried forward coverage won't be shown. Click here to find out more. |
…al version of phdi.linkage
…d comment on tabulation
|
wrapped up everything (except FHIR server; have a question on that one for Dan when he's back) |
… doc, added PHDI rec to requirements
There was a problem hiding this comment.
@robertmitchellv this is looking really great! Thanks for your work here. Before merging I think we can simplify some of our unit testing. The services that use the /health-check endpoint from base_service no longer need to have that endpoint covered by the service specific unit test since we have unit test coverage for this endpoint in phdi. Could these, unit tests that are now redundant be removed as part of this PR?
|
Thanks Dan; yes, absolutely, I can work on that this morning. |
…in `phdi`; all tests pass on local
|
Tests are passing on local--I built the docker container for the building block locally to see what was going on--looks like a shell command is trying to remove something that isn't there: Step 5/20 : RUN rm src/Microsoft.Health.Fhir.TemplateManagement.UnitTests/TestData/DecompressedFiles/.wh.VXU_V04.liquid
---> Running in 09851ded28aa
rm: cannot remove 'src/Microsoft.Health.Fhir.TemplateManagement.UnitTests/TestData/DecompressedFiles/.wh.VXU_V04.liquid': No such file or directory
The command '/bin/sh -c rm src/Microsoft.Health.Fhir.TemplateManagement.UnitTests/TestData/DecompressedFiles/.wh.VXU_V04.liquid' returned a non-zero code: 1Will work on fixing this error. |
…dded a test for passing license dict to FastAPI
…md, passed the MIT license as optional param to BaseService
PULL REQUEST
Summary
For most of the container apps'
main.pythere is boilerplate metadata being passed toFastAPI. In an effort to be more DRY,phdi.containers.base_serviceoffers aBaseServiceclass to handle the redundancies.Related Issue
Fixes ? (not sure if there is already an issue for this)