Add additional param to the BaseService class to allow for passing other licenses to FastAPI #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed a test to pass a different license as a dict and tests pass locally
robertmitchellv
requested review from
m-goggins,
emmastephenson,
gordonfarrell,
DanPaseltiner and
KennethSkylight
Codecov Report
@@ Coverage Diff @@
## main #526 +/- ##
=======================================
Coverage 96.48% 96.49%
=======================================
Files 45 45
Lines 2473 2479 +6
=======================================
+ Hits 2386 2392 +6
Misses 87 87
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…sn't added in the test for it
|
This one is wrapped up and ready now--didn't notice the changes from #517 with the inclusion of |
DanPaseltiner
approved these changes
May 5, 2023
Comment on lines
12
to
15
| default_app_license = { | ||
| "name": "Creative Commons Zero v1.0 Universal", | ||
| "url": "https://creativecommons.org/publicdomain/zero/1.0/", | ||
| } |
There was a problem hiding this comment.
Looks like this dictionary is also defined in base_service.py. Could we DRY this out a bit?
…-license-param-baseservice
… it's an enum of two types (for now) with contact moved as a class variable
…-license-param-baseservice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Added a
license_infoparam that is adictwith a default value that matches all DIBBs defaults for the container apps inphdi/containers. Given thefhir-converteris pulling a Microsoft base image in its Dockerfile and using Micosoft's FHIR Converter we should make a best effort to pass its MIT license and add it to thedescription.mdfor thefhir-converter, which is already done in #520Related Issue
Fixes #520