Update Record Linkage Container to utilize and make the external person id accessible #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…update the external person id in the person table
…e new person function
…pt an external_person_id and return a bool matched based upon the results
This makes sense. I think I was too tired last night. ;) Co-authored-by: Daniel Paseltiner <99684231+DanPaseltiner@users.noreply.github.com>
…thub.com/CDCgov/phdi into brady/add-external-person-id-mpi-seeding
BradySkylight
requested review from
nickclyde,
m-goggins,
emmastephenson and
DanPaseltiner
Codecov Report
@@ Coverage Diff @@
## main #599 +/- ##
=======================================
Coverage 96.46% 96.46%
=======================================
Files 45 45
Lines 2516 2516
=======================================
Hits 2427 2427
Misses 89 89
Flags with carried forward coverage won't be shown. Click here to find out more. |
nickclyde
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
I was able to get the external id added to the sdk and to the container (for the most part) and got tests updated and passing. Once this has been merged into main then I can do another PR to get the external id in the container so that it matches the existing SDK in main and then the tests will pass. I am working on an Azure PR now to update the MPI seeding script.
This is the update to make the container use the functionality in the updated SDK
Related Issue
Fixes #?