Remove the DocumentReference from the EICR templates for the FHIR Converter #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #608 +/- ##
=======================================
Coverage 96.46% 96.46%
=======================================
Files 45 45
Lines 2516 2516
=======================================
Hits 2427 2427
Misses 89 89
Flags with carried forward coverage won't be shown. Click here to find out more.
|
emmastephenson
approved these changes
May 22, 2023
…ic in common version
…l instead of typing
DanPaseltiner
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
During the LAC UAT data run for testing it was found that a single EICR message after it was converted into FHIR was too large for the Azure network to handle when passing into the standardization functionality in the pipeline. To help prevent this error in the future we are removing one of the largest sections in the EICR FHIR Messages. This is the DocumentReference resource that contained a full zip of the actual EICR message in it. This is NOT required in the ECR FHIR Specifications as defined by HL7 and seems beyond redundant for our purposes. We still may run into this same error if there is an extremely large EICR message, however, this will help prevent it from happing for the majority of EICR messages.
Related Issue
Fixes #CDCgov/phdi-azure#129