Update python #647
Merged
Update python #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #647 +/- ##
=======================================
Coverage 96.37% 96.37%
=======================================
Files 45 45
Lines 2538 2539 +1
=======================================
+ Hits 2446 2447 +1
Misses 92 92
Flags with carried forward coverage won't be shown. Click here to find out more. |
nickbristow
reviewed
Jun 13, 2023
| phdi | ||
| pydantic==1.10.9 | ||
| fastapi==0.96.0 | ||
| phdi @ git+https://github.com/CDCgov/phdi@updatepython |
There was a problem hiding this comment.
change this before merging
nickbristow
reviewed
Jun 13, 2023
| typing_extensions==4.6.3 | ||
| pydantic==1.10.9 | ||
| fastapi==0.96.0 | ||
| phdi @ git+https://github.com/CDCgov/phdi@updatepython |
There was a problem hiding this comment.
also change before merging
nickbristow
reviewed
Jun 13, 2023
| phdi | ||
| pydantic==1.10.9 | ||
| fastapi==0.96.0 | ||
| phdi @ git+https://github.com/CDCgov/phdi@updatepython |
nickbristow
reviewed
Jun 13, 2023
| phdi @ git+https://github.com/CDCgov/phdi@main | ||
| pydantic==1.10.9 | ||
| fastapi==0.96.0 | ||
| phdi @ git+https://github.com/CDCgov/phdi@updatepython |
nickbristow
reviewed
Jun 13, 2023
| phdi | ||
| pydantic==1.10.9 | ||
| fastapi==0.96.0 | ||
| phdi @ git+https://github.com/CDCgov/phdi@updatepython |
nickbristow
reviewed
Jun 13, 2023
| phdi | ||
| pydantic==1.10.9 | ||
| fastapi==0.96.0 | ||
| phdi @ git+https://github.com/CDCgov/phdi@updatepython |
nickbristow
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Python
Summary
Updating python to 3.11 and related packages. There is a slight workaround where we have to point the repo to this branch as we cut the new release of phdi to pypi. The containers on this project are dependent on the pypi version of phdi but since those are still on the old packages, it creates a somewhat circular logic when updating python.
For now, we can point the phdi package to this github branch and then when we make a new release, we have to reupdate the release to point it back to pypi.
Related Issue
Fixes #399