Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shallow-water equations on the cubed-sphere miniapp #550

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

valeriabarra
Copy link
Contributor

@valeriabarra valeriabarra commented Jun 3, 2020

This is a WIP PR for the development of the shallow-water equations solver miniapp.

Note: This PR moves the fluids/navierstokes miniapp into the subdirectory fluids/navier-stokes/navierstokes (relative Makefile and .gitignore files already updated, as well as tests/junit.py and tests/tap.sh).

TODOs:

  • Finish development of Jacobian action part
  • Debugging..................
  • Add good test/problem case(s) Edit: Added Advection of cosine bell, but the geostrophic problem case is not complete yet
  • Add TESTARGS test run options for CI
  • Add documentation in user-manual. Edit: Need to add description of different problem types

@valeriabarra valeriabarra marked this pull request as draft June 3, 2020 17:15
@valeriabarra valeriabarra force-pushed the valeria/shallow-water branch from c33bf84 to 83dc762 Compare June 3, 2020 17:16
@valeriabarra valeriabarra force-pushed the valeria/shallow-water branch 4 times, most recently from 8855b13 to 491d6ab Compare July 7, 2020 17:32
@valeriabarra valeriabarra changed the base branch from master to main July 8, 2020 22:01
@valeriabarra valeriabarra force-pushed the valeria/shallow-water branch 3 times, most recently from b28bed6 to 0136af5 Compare July 17, 2020 15:27
@valeriabarra valeriabarra force-pushed the valeria/shallow-water branch from 7361d3d to a6185a2 Compare July 27, 2020 17:24
@valeriabarra valeriabarra force-pushed the valeria/shallow-water branch from 1fa55d6 to a653fb1 Compare August 4, 2020 20:46
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #550 into main will decrease coverage by 1.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   98.06%   96.50%   -1.57%     
==========================================
  Files         250      234      -16     
  Lines       16077    15788     -289     
==========================================
- Hits        15766    15236     -530     
- Misses        311      552     +241     
Flag Coverage Δ
#backends 96.26% <ø> (-1.40%) ⬇️
#examples 76.54% <ø> (-10.00%) ⬇️
#gallery 54.34% <ø> (-45.66%) ⬇️
#interface 93.87% <ø> (-1.03%) ⬇️
#tests 99.98% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gallery/mass3d/ceed-mass3dbuild.h 0.00% <0.00%> (-100.00%) ⬇️
gallery/poisson1d/ceed-poisson1dapply.h 0.00% <0.00%> (-100.00%) ⬇️
gallery/poisson1d/ceed-poisson1dbuild.h 0.00% <0.00%> (-100.00%) ⬇️
gallery/poisson3d/ceed-poisson3dapply.h 0.00% <0.00%> (-100.00%) ⬇️
gallery/poisson3d/ceed-poisson3dbuild.h 0.00% <0.00%> (-100.00%) ⬇️
gallery/poisson1d/ceed-poisson1dbuild.c 15.38% <0.00%> (-84.62%) ⬇️
gallery/poisson3d/ceed-poisson3dbuild.c 15.38% <0.00%> (-84.62%) ⬇️
gallery/mass3d/ceed-mass3dbuild.c 16.66% <0.00%> (-83.34%) ⬇️
gallery/poisson1d/ceed-poisson1dapply.c 18.18% <0.00%> (-81.82%) ⬇️
gallery/poisson3d/ceed-poisson3dapply.c 18.18% <0.00%> (-81.82%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb15575...8d9ad6f. Read the comment docs.

@valeriabarra valeriabarra requested a review from jedbrown August 24, 2020 04:36
@valeriabarra valeriabarra marked this pull request as ready for review September 2, 2020 20:22
@valeriabarra valeriabarra force-pushed the valeria/shallow-water branch 2 times, most recently from 31f2588 to 050b365 Compare September 3, 2020 21:06
@valeriabarra valeriabarra force-pushed the valeria/shallow-water branch 2 times, most recently from fb02c59 to 8d9ad6f Compare September 23, 2020 03:30
@valeriabarra valeriabarra force-pushed the valeria/shallow-water branch from 8d9ad6f to d2f5d15 Compare November 9, 2020 18:09
@valeriabarra valeriabarra marked this pull request as draft January 6, 2021 02:24
@LeilaGhaffari LeilaGhaffari force-pushed the valeria/shallow-water branch from d2f5d15 to 2ccc907 Compare March 9, 2021 22:21
valeriabarra and others added 25 commits March 20, 2021 23:34
…n the cube edges

The algorithm with bit manipulation was greatly inspired-by and helped-by @matteovigni

Thanks-to @matteovigni
…l coordinate systems on different panels (faces) of the cube
This generic restriction matrix does not only have 1's but also the coordinate transformations needed from the coord system of the nodes that are on the panel edges (lat, long) to the local ones of the nodes on the adjacent panels
@LeilaGhaffari LeilaGhaffari force-pushed the valeria/shallow-water branch from 94234d0 to da12e01 Compare March 21, 2021 05:36
@valeriabarra valeriabarra mentioned this pull request Sep 27, 2021
@jedbrown jedbrown linked an issue Sep 28, 2021 that may be closed by this pull request
@valeriabarra
Copy link
Contributor Author

@LeilaGhaffari , @jedbrown , I don't know if anyone is planning to potentially continue this work. But I guess it is ok to close for now? (Can always be restored, if desired)

@jedbrown
Copy link
Member

I think it's worth leaving this PR open so the branch is saved. It may be that a fresh effort would start from main and cherry-pick docs and code from this branch, rather than trying to rebase this branch or merge main into this branch.

FYSA, we have a new SciDAC to develop models for compound flooding. Our effort at present is using finite volume methods (and will express them using libCEED for GPU efficiency), but we would like to compare FE methods. It's on unstructured grids and our tests thus far are regional (rather than global), but I expect some of the work in this branch will be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SWE example
3 participants