Modernize CMake code

[kheaactua]

Status

For the moment this is still a WIP. I would love community feedback on this PR so that we can produce a modern CMake setup that functions well for everyone.

I suspect the cleanest way to organize the commits would be to squash them.

Description

General CMakeLists improvements - cmake v2→v3

• Included a .cmake-format file, and ran applied it to the main CMakeList files in this project.
  • The format file does a poor job on if and foreach blocks, but I believe overall it does a better job that the default settings. The main benefit is a consistent format
• Use targets instead of lib/include variables in CMake
• Write internal.hpp to build directory instead of source to prevent needless rebuilds
  • The include directives for this file are also updated in the code to use include paths rather than relative paths.
• Remove hard coded CMAKE_VERBOSE_MAKEFILE, this should be injected by the user if so desired
• "wrap"ing (ld's --wrap option) the "socket" symbol, see wrappers.cpp
• Added install directive to vsomeip/example/hello_world and vsomeip_ctrl
• Platform conditional socket lib linkage
• hello_world code uses ENABLE_SIGNALS, but its setting was missing in CMake
• Improve setup for boost stacktrace, really only helps on Linux and requires the backtrace.h file
• Added QNX platform section, though the credential code changes for QNX are not included in this commit.
• Use a CACHE variable for VSOMEIP_BASE_PATH. Upstream defaults this to /var for QNX which is a very bad choice.

Misc

• Added more ignore rules to for common IDEs

[duartenfonseca]

why did you separated this flag from the others related to LINUX?

[kheaactua]

The -Werror blocks my linux builds :) Honestly I don't think any component should ever include this. -Werror should be up to the toolchain - as the toolchain usually specifies which compile options to use, which warnings to watch for, and whether warnings should be allowed.

[kheaactua]

I am still working on this PR, I'll likely rebase to Fabio's 3.5.x branch. Stuff just takes time. :)

[duartenfonseca]

I am still working on this PR, I'll likely rebase to Fabio's 3.5.x branch. Stuff just takes time. :)

In that case maybe i will check this PR later! great job anyway, it has interesting improvements

[duartenfonseca]

@kheaactua tried to build this new CMake code and got a failure.
I did :
cmake -B build
cmake --build build

I have ubuntu 22.04, gcc version 11.4

the error i got was the following:
/home/duartef/repos/covesa/vsomeip_duarte/vsomeip/implementation/endpoints/src/../../routing/include/../../endpoints/include/netlink_connector.hpp:197:47: error: ‘VSOMEIP_MAX_NETLINK_RETRIES’ was not declared in this scope
197 | static const std::uint32_t max_retries_ = VSOMEIP_MAX_NETLINK_RETRIES;

[kheaactua]

@duartenfonseca I'll take a look! Was this on Fabio's 3.5.x? He did push a change to the network tests a few days back.

I'll also fix that conflict that appeared.

[duartenfonseca]

@kheaactua i just did a checkout to your branch and tried to build!

[duartenfonseca]

@kheaactua is the increase of minimum version on cmake is really necessary? from our side, we would like to avoid that

[kheaactua]

@kheaactua is the increase of minimum version on cmake is really necessary? from our side, we would like to avoid that

I raised it to 3.15 to accommodate Conan 2.0. From the author:

Conan 2.0 requires at least CMake 3.15.

Though not yet posted, I've been prepping covesa/capi-conan, covesa/capi-docker, and some others that all use Conan to set up CommonAPI environments.

Curious though, what would be desirable about staying at 3.13? With 3.23 vsomeip could use file sets for a cleaner install of the includes

Locally I jack it up to 3.30 :)