Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize CMake code #734

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Modernize CMake code #734

wants to merge 4 commits into from

Commits on Oct 3, 2024

  1. Ran cmake-format 

    Included a .cmake-format file, and ran applied it to the main CMakeList files in this project.
    @kheaactua
    kheaactua committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    128d668 View commit details
    Browse the repository at this point in the history

  2. Added more ignore rules to for common IDEs

    @kheaactua
    kheaactua committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d719697 View commit details
    Browse the repository at this point in the history

  3. General CMakeLists improvements - cmake v2→v3 

    - Use literal target names instead of variables
- Write internal.hpp to build directory instead of source to prevent needless rebuilds
  - Fixed how this file is includes in source files
- Remove hard coded CMAKE_VERBOSE_MAKEFILE
- Ran cmake-format
- "wrap"ing (ld's --wrap option) the "socket" symbol, see wrappers.cpp
- Added install directive to vsomeip/example/hello_world and
  vsomeip_ctrl
- Platform conditional socket lib linkage
- hello_world code uses ENABLE_SIGNALS, but its setting was missing in CMake
- Improve setup for boost stacktrace, really only helps on Linux and
  requires the backtrace.h file
- Added QNX platform section, though the credential code changes for QNX
  are not included in this commit.
- Use a CACHE variable for VSOMEIP_BASE_PATH.  Upstream defaults this to
  /var for QNX which is a very bad choice.
- Followed the 3.5.x example and remove the dependency on routingmanager
  in the tests, as it's not available on Windows
    @kheaactua
    kheaactua committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    f3cabc5 View commit details
    Browse the repository at this point in the history

  4. Updating Hello World example CMakeLists 

    Co-authored-by: "Duarte Fonseca" <Duarte.Fonseca@ctw.bmwgroup.com>
Co-authored-by: "Matthew Russell" <matthew.g.russell@gmail.com>
    @kheaactua
    Duarte Fonseca and kheaactua committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    0c2f5f9 View commit details
    Browse the repository at this point in the history