feat: Change `TypeParam::USize` to `TypeParam::BoundedNat` and use in int extensions #445

ss2165 · 2023-08-22T16:27:01Z

Closes #437

BREAKING CHANGE: USize type param and type arg changed to BoundedNat with optional maximum. For previous behaviour use TypeParam::max_nat()

ss2165

Tests pass but I think logic like
typ.clone() == int_custom_type(self.width)

is incorrect because now the parameter should be the log width (requires updating the field stored in the contents to log width)

acl-cqc · 2023-08-23T09:33:48Z

src/std_extensions/arithmetic/int_types.rs

-    };
-    if !is_valid_width(n) {
-        return Err(TypeArgError::InvalidValue(arg.clone()).into());
+pub fn get_width_power(arg: &TypeArg) -> u8 {


I am a bit confused by this width_power nomenclature. What this returns is an integer width, right? A widely-understood concept being the number of bits in the int representation. It can be seen as a power of the tag of the SimplePredicate, but I don't think that really helps - indeed that's a description of the implementation of this method, but the purpose of this method is to isolate the details of this encoding from the rest of the method, right? Once I've got it, it's a width, I'm not expecting to take logarithm or do anything fancy with it, right?

So, alternative suggestions for naming:

int_width_as_power_of_simple_predicate clearly too long but maximally explicit

int_width_as_power shortened form of previous

int_width_from_typearg, int_width_from_tag, int_width_from_simp_pred / int_width_from_sum etc.

or maybe just int_width or get_width...

it should be get_log_width, I would like to use the log of the width everywhere

Yes, actually that was my initial suspicion!! Lol.

However, I see that this is only used in tests; in prod code. it is always followed immediately by passing the returned value to int_type. So you could just have one function int_type_from_type_arg (or similar) that does both together and I think that would completely avoid the opportunity for confusion

hmmm, if it's called get_log_width I think that'd be clear, ok. Note the checks in int_ops.rs (that n>m etc.) would be equally valid on the actual width, if that was easier (probably not). Moreover, int_type is actually performing the inverse operation to this, so this is just validating - i.e. panicking....

changed so int_type is just constructed from the arg directly, and the checks are performed on the log width where necessary

now fewer lines overall!

acl-cqc · 2023-08-23T09:34:38Z

src/std_extensions/arithmetic/int_types.rs

@@ -30,37 +29,22 @@ fn int_custom_type(n: u8) -> CustomType {
 /// Integer type of a given bit width.
 /// Depending on the operation, the semantic interpretation may be unsigned integer, signed integer
 /// or bit string.
-pub fn int_type(n: u8) -> Type {
-    Type::new_extension(int_custom_type(n))
+pub fn int_type(width_power: u8) -> Type {


Comment says this is "a given bit width". It certainly looks like it's just a width rather than a width_power whatever one of those is. (Same confusion as other comment, IOW)

see my comment above - I have not updated docs (or even the consts for that matter), just getting initial feedback on the idea for now

acl-cqc

Ok, so apart from confusion about the terminology of width_power this looks great to me :-)

cqc-alec · 2023-08-23T10:27:36Z

src/types/type_param.rs

@@ -21,6 +21,9 @@ pub enum TypeParam {
    Type(TypeBound),
    /// Argument is a [TypeArg::USize].
    USize,
+    /// Argument is a [TypeArg::SimplePredicate] which is bounded by the size
+    /// specified here.
+    SimplePredicate(usize),


Would it be possible to call this something like BoundedUsize which is more descriptive, even if it is implemented as a sum type?

I'd like to maintain the analogy with predicates in the main type system, but I agree a more descriptive name would be better. Maybe UnitPredicate (and update simple predicate to that in the main code base too?)

I was thinking the same (BoundedUSize) but I take your argument. Really I think "predicate" is the wrong word to start. We're calling it that because we use it to control branches, but IMHO predicate is inherently binary - true or false - Google gives me this:

LOGIC
something which is affirmed or denied concerning an argument of a proposition

So perhaps go with predicate for now but a better word might be "selector" or "choice"? or wilder ideas like "Nway"

I like Choice.

Yeah I can make a new issue for that rename, and that can cover this too when it is done.

Yeah that works - the yaml syntax could offer "bool" which maps to Usize(bound: 2)

though I prefer then BoundedU as the only one, with the default being the maximum (BoundedU(u64::MAX))

Yes, I was meaning the Option to express the idea of defaulting to None, too

I'd still approve of renaming Predicate to Choice, but if that can be made to work it sounds quite appealing.

yeah I think that is a separate task in the main codebase

cqc-alec · 2023-08-23T10:29:33Z

src/std_extensions/arithmetic/int_types.rs

+pub fn get_width_power(arg: &TypeArg) -> u8 {
+    match arg {
+        TypeArg::SimplePredicate(n) if *n < POWERS_OF_TWO => *n as u8,
+        _ => panic!("type check should prevent this."),


Should this really be a panic rather than an error? The tests demonstrate that it's possible to invoke via the public API, I think?

yes - I agree with alan that this function shouldn't be in the public API

actually no - it's used in int_ops for operation specific width checks

and fix doclinks

src/std_extensions/arithmetic/int_types.rs

src/std_extensions/arithmetic/int_ops.rs

acl-cqc · 2023-08-23T15:52:28Z

src/std_extensions/arithmetic/int_types.rs

-pub fn int_type(n: u8) -> Type {
-    Type::new_extension(int_custom_type(n))
+pub fn int_type(width_arg: TypeArg) -> Type {
+    Type::new_extension(int_custom_type(width_arg))


Given this function is pub (should it be??), you should probably do some validation here. Or are we leaving that to when we have the extension registry available in Hugr::validate?

So lots of things:

The function was only used by the operation definitions, which should have their arguments validated also, so I have just made this method pub(super).

However, the ops all listed their type params as TypeParam::max_usize(), which is incorrect! Now they all list the correct bounded parameter, so the check should happen.

Noting that direct access to valid integer types might be useful, I've added a lazy static array of the valid types. So all pub access should be correctly validated.

All that is to say...I wish we had more tests of this.

acl-cqc · 2023-08-23T15:53:41Z

src/types/type_param.rs

@@ -33,14 +33,21 @@ pub enum TypeParam {
    Extensions,
 }

+impl TypeParam {
+    /// [`TypeParam::BoundedUSize`] with the maximum bound (`u64::MAX`)
+    pub const fn max_usize() -> Self {


This works nicely :)

acl-cqc · 2023-08-23T15:54:20Z

src/types/type_param.rs

-    /// Instance of [TypeParam::USize]. 64-bit unsigned integer.
-    USize(u64),
+    /// Instance of [TypeParam::BoundedUSize]. 64-bit unsigned integer.
+    BoundedUSize(u64),


Given this is only the value and nothing about the bound I wonder if it should still be called USize but I agree it's nice to have the name correspond with the TypeParam

Yeah I want to be able to call it BoundedNat...

I'd be OK with that.

The other thing that slightly grates is that the parameter is the maximum allowed value rather than the minimum excluded value, which would be more consistent with range conventions and also allow us to define an instance with 0 values, but if we made that change we'd either have to make the parameter a u128 or not allow 2^64-1 as a value; not sure I like either of those options though both probably harmless.

yes I only made that choice for that reason. I don't like not allowing 2^64 -1, that could lead to surprising failures. making the parameter a u128 is probably fine though.

going the whole hog in commit d13a4c1 to use an Option to encode the bound in the same size as a u64.

Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>

src/std_extensions/arithmetic/int_types.rs

Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>

cqc-alec · 2023-08-24T09:57:45Z

src/std_extensions/arithmetic/int_types.rs

+/// Type parameter for the log width of the integer.
+// SAFETY: unsafe block should be ok as the value is definitely not zero.
+pub const LOG_WIDTH_TYPE_PARAM: TypeParam =
+    TypeParam::bounded_nat(unsafe { NonZeroU64::new_unchecked(MAX_LOG_WIDTH as u64 + 1) });


Would this be avoidable by using a macro definition for MAX_LOG_WIDTH, so that the compiler can see that it's a safe value? @aborgna-q ?

The safe alternative is to use new() but that produces an option (None if you gave it zero). We could happily unwrap it...but unwrap is not const yet, in the works.

our miri CI check should check this is fine

We can't do NonZeroU64::new(...).unwrap() here because panicking operations (like unwrap) cannot be const.

The unsafe is run at compile time though, so there can't be any UB here.

… int extensions (#445) Closes #437 BREAKING CHANGE: `USize` type param and type arg changed to `BoundedNat` with optional maximum. For previous behaviour use `TypeParam::max_nat()` --------- Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>

## 🤖 New release * `quantinuum-hugr`: 0.1.0 <details><summary>Changelog</summary> <blockquote> ## 0.1.0 (2024-01-15) ### Bug Fixes - Subgraph boundaries with copies ([#440](#440)) - [**breaking**] Use internal tag for SumType enum serialisation ([#462](#462)) - Check kind before unwrap in insert_identity ([#475](#475)) - Allow for variables to get solved in inference ([#478](#478)) - In IdentityInsertion add noop to correct parent ([#477](#477)) - Failing release tests ([#485](#485)) - [**breaking**] Serialise `Value`, `PrimValue`, and `TypeArg` with internal tags ([#496](#496)) - Serialise custom constants with internal tag ([#502](#502)) - [**breaking**] Reduce max int width in arithmetic extension to 64 ([#504](#504)) - HugrView::get_function_type ([#507](#507)) - TODO in resolve_extension_ops: copy across input_extensions ([#510](#510)) - Use given input extensions in `define_function` ([#524](#524)) - Lessen requirements for hugrs in outline_cfg ([#528](#528)) - Make unification logic less strict ([#538](#538)) - Simple replace incorrectly copying metadata ([#545](#545)) - Account for self-referencial constraints ([#551](#551)) - Consider shunted metas when comparing equality ([#555](#555)) - Join labels in issue workflow ([#563](#563)) - Comment out broken priority code ([#562](#562)) - Handling of issues with no priority label ([#573](#573)) - Don't insert temporary wires when extracting a subgraph ([#582](#582)) - Improve convexity checking and fix test ([#585](#585)) - Ignore input->output links in SiblingSubgraph::try_new_dataflow_subgraph ([#589](#589)) - Enforce covariance of SiblingMut::RootHandle ([#594](#594)) - Erratic stack overflow in infer.rs (live_var) ([#638](#638)) - Work harder in variable instantiation ([#591](#591)) - Actually add the error type to prelude ([#672](#672)) - Serialise dynamically computed opaqueOp signatures ([#690](#690)) - FuncDefns don't require that their extensions match their children ([#688](#688)) - Binary compute_signature returning a PolyFuncType with binders ([#710](#710)) - Use correct number of args for int ops ([#723](#723)) - [**breaking**] Add serde tag to TypeParam enum ([#722](#722)) - Allow widening and narrowing to same width. ([#735](#735)) - Case node should not have an external signature ([#749](#749)) - [**breaking**] Normalize input/output value/static/other ports in `OpType` ([#783](#783)) - No dataflow_signature for block types ([#792](#792)) - Ignore unsupported test in miri ([#794](#794)) - Include schema rather than read file ([#807](#807)) ### Documentation - Add operation constraint to quantum extension ([#543](#543)) - Coverage check section in DEVELOPMENT.md ([#648](#648)) - Remove "quantum extension" from HUGR spec. ([#694](#694)) - Improve crate-level docs, including example code. ([#698](#698)) - Spec cleanups and clarifications ([#742](#742)) - Spec clarifications ([#738](#738)) - Spec updates ([#741](#741)) - [spec] Remove references to causal cone and Order edges from Input ([#762](#762)) - Mention experimental inference in readme ([#800](#800)) - Collection of spec updates for 0.1 ([#801](#801)) - Add schema v0 ([#805](#805)) - Update spec wrt. polymorphism ([#791](#791)) ### Features - Derive things for builder structs ([#229](#229)) - Return a slice of types from the signature ([#238](#238)) - Move `dot_string` to `HugrView` ([#271](#271)) - [**breaking**] Change `TypeParam::USize` to `TypeParam::BoundedNat` and use in int extensions ([#445](#445)) - TKET2 compatibility requirements ([#450](#450)) - Split methods between `HugrMut` and `HugrMutInternals` ([#441](#441)) - Add `HugrView::node_connections` to get all links between nodes ([#460](#460)) - Location information in extension inference error ([#464](#464)) - Add T, Tdg, X gates ([#466](#466)) - [**breaking**] Add `ApplyResult` associated type to `Rewrite` ([#472](#472)) - Implement rewrite `IdentityInsertion` ([#474](#474)) - Instantiate inferred extensions ([#461](#461)) - Default DFG builders to open extension sets ([#473](#473)) - Some helper methods ([#482](#482)) - Extension inference for conditional nodes ([#465](#465)) - Add ConvexChecker ([#487](#487)) - Add clippy lint for mut calls in a debug_assert ([#488](#488)) - Default more builder methods to open extension sets ([#492](#492)) - Port is serializable ([#489](#489)) - More general portgraph references ([#494](#494)) - Add extension deltas to CFG ops ([#503](#503)) - Implement petgraph traits on Hugr ([#498](#498)) - Make extension delta a parameter of CFG builders ([#514](#514)) - [**breaking**] SiblingSubgraph does not borrow Hugr ([#515](#515)) - Validate TypeArgs to ExtensionOp ([#509](#509)) - Derive Debug & Clone for `ExtensionRegistry`. ([#530](#530)) - Const nodes are built with some extension requirements ([#527](#527)) - Some python errors and bindings ([#533](#533)) - Insert_hugr/insert_view return node map ([#535](#535)) - Add `SiblingSubgraph::try_from_nodes_with_checker` ([#547](#547)) - PortIndex trait for undirected port parameters ([#553](#553)) - Insert/extract subgraphs from a HugrView ([#552](#552)) - Add `new_array` operation to prelude ([#544](#544)) - Add a `DataflowParentID` node handle ([#559](#559)) - Make TypeEnum and it's contents public ([#558](#558)) - Optional direction check when querying a port index ([#566](#566)) - Extension inference for CFGs ([#529](#529)) - Better subgraph verification errors ([#587](#587)) - Compute affected nodes for `SimpleReplacement` ([#600](#600)) - Move `SimpleReplace::invalidation_set` to the `Rewrite` trait ([#602](#602)) - [**breaking**] Resolve extension ops (mutating Hugr) in (infer_and_->)update_validate ([#603](#603)) - Add accessors for node index and const values ([#605](#605)) - [**breaking**] Expose the value of ConstUsize ([#621](#621)) - Nicer debug and display for core types ([#628](#628)) - [**breaking**] Static checking of Port direction ([#614](#614)) - Builder and HugrMut add_op_xxx default to open extensions ([#622](#622)) - [**breaking**] Add panicking integer division ops ([#625](#625)) - Add hashable `Angle` type to Quantum extension ([#608](#608)) - [**breaking**] Remove "rotations" extension. ([#645](#645)) - Port.as_directed to match on either direction ([#647](#647)) - Impl GraphRef for PetgraphWrapper ([#651](#651)) - Provide+implement Replace API ([#613](#613)) - Require the node's metadata to always be a Map ([#661](#661)) - [**breaking**] Polymorphic function types (inc OpDefs) using dyn trait ([#630](#630)) - Make prelude error type public ([#669](#669)) - Shorthand for retrieving custom constants from `Const`, `Value` ([#679](#679)) - [**breaking**] HugrView API improvements ([#680](#680)) - Make FuncDecl/FuncDefn polymorphic ([#692](#692)) - [**breaking**] Simplify `SignatureFunc` and add custom arg validation. ([#706](#706)) - [**breaking**] Drop the `pyo3` feature ([#717](#717)) - [**breaking**] `OpEnum` trait for common opdef functionality ([#721](#721)) - MakeRegisteredOp trait for easier registration ([#726](#726)) - Getter for `PolyFuncType::body` ([#727](#727)) - `Into<OpType>` for custom ops ([#731](#731)) - Always require a signature in `OpaqueOp` ([#732](#732)) - Values (and hence Consts) know their extensions ([#733](#733)) - [**breaking**] Use ConvexChecker trait ([#740](#740)) - Custom const for ERROR_TYPE ([#756](#756)) - Implement RemoveConst and RemoveConstIgnore ([#757](#757)) - Constant folding implemented for core and float extension ([#769](#769)) - Constant folding for arithmetic conversion operations ([#720](#720)) - DataflowParent trait for getting inner signatures ([#782](#782)) - Constant folding for logic extension ([#793](#793)) - Constant folding for list operations ([#795](#795)) - Add panic op to prelude ([#802](#802)) - Const::from_bool function ([#803](#803)) ### HugrMut - Validate nodes for set_metadata/get_metadata_mut, too ([#531](#531)) ### HugrView - Validate nodes, and remove Base ([#523](#523)) ### Miscellaneous Tasks - [**breaking**] Update portgraph 0.10 and pyo3 0.20 ([#612](#612)) - [**breaking**] Hike MSRV to 1.75 ([#761](#761)) ### Performance - Use lazy static definittion for prelude registry ([#481](#481)) ### Refactor - Move `rewrite` inside `hugr`, `Rewrite` -> `Replace` implementing new 'Rewrite' trait ([#119](#119)) - Use an excluded upper bound instead of max log width. ([#451](#451)) - Add extension info to `Conditional` and `Case` ([#463](#463)) - `ExtensionSolution` only consists of input extensions ([#480](#480)) - Remove builder from more DFG tests ([#490](#490)) - Separate hierarchy views ([#500](#500)) - [**breaking**] Use named struct for float constants ([#505](#505)) - Allow NodeType::new to take any Into<Option<ExtensionSet>> ([#511](#511)) - Move apply_rewrite from Hugr to HugrMut ([#519](#519)) - Use SiblingSubgraph in SimpleReplacement ([#517](#517)) - CFG takes a FunctionType ([#532](#532)) - Remove check_custom_impl by inlining into check_custom ([#604](#604)) - Insert_subgraph just return HashMap, make InsertionResult new_root compulsory ([#609](#609)) - [**breaking**] Rename predicate to TupleSum/UnitSum ([#557](#557)) - Simplify infer.rs/report_mismatch using early return ([#615](#615)) - Move the core types to their own module ([#627](#627)) - Change &NodeType->&OpType conversion into op() accessor ([#623](#623)) - Infer.rs 'fn results' ([#631](#631)) - Be safe ([#637](#637)) - NodeType constructors, adding new_auto ([#635](#635)) - Constraint::Plus stores an ExtensionSet, which is a BTreeSet ([#636](#636)) - [**breaking**] Remove `SignatureDescription` ([#644](#644)) - [**breaking**] Remove add_op_<posn> by generalizing add_node_<posn> with "impl Into" ([#642](#642)) - Rename accidentally-changed Extension::add_node_xxx back to add_op ([#659](#659)) - [**breaking**] Remove quantum extension ([#670](#670)) - Use type schemes in extension definitions wherever possible ([#678](#678)) - [**breaking**] Flatten `Prim(Type/Value)` in to parent enum ([#685](#685)) - [**breaking**] Rename `new_linear()` to `new_endo()`. ([#697](#697)) - Replace NodeType::signature() with io_extensions() ([#700](#700)) - Validate ExtensionRegistry when built, not as we build it ([#701](#701)) - [**breaking**] One way to add_op to extension ([#704](#704)) - Remove Signature struct ([#714](#714)) - Use `MakeOpDef` for int_ops ([#724](#724)) - [**breaking**] Use enum op traits for floats + conversions ([#755](#755)) - Avoid dynamic dispatch for non-folding operations ([#770](#770)) - Simplify removeconstignore verify ([#768](#768)) - [**breaking**] Unwrap BasicBlock enum ([#781](#781)) - Make clear const folding only for leaf ops ([#785](#785)) - [**breaking**] `s/RemoveConstIgnore/RemoveLoadConstant` ([#789](#789)) - Put extension inference behind a feature gate ([#786](#786)) ### SerSimpleType - Use Vec not TypeRow ([#381](#381)) ### SimpleReplace+OutlineCfg - Use HugrMut methods rather than .hierarchy/.graph ([#280](#280)) ### Testing - Update inference test to not use DFG builder ([#550](#550)) - Strengthen "failing_sccs_test", rename to "sccs" as it's not failing! ([#660](#660)) - [**breaking**] Improve coverage in signature and validate ([#643](#643)) - Use insta snapshots to add dot_string coverage ([#682](#682)) - Miri ignore file-opening test ([#684](#684)) - Unify the serialisation tests ([#730](#730)) - Add schema validation to roundtrips ([#806](#806)) ### `ConstValue - :F64` and `OpaqueOp::new` ([#206](#206)) ### Cleanup - Remove outdated comment ([#536](#536)) ### Cosmetic - Format + remove stray TODO ([#444](#444)) ### Doc - Crate name as README title + add reexport ([#199](#199)) ### S/EdgeKind - :Const/EdgeKind::Static/ ([#201](#201)) ### Simple_replace.rs - Use HugrMut::remove_node, includes clearing op_types ([#242](#242)) ### Spec - Remove "Draft 3" from title of spec document. ([#590](#590)) - Rephrase confusing paragraph about TailLoop inputs/outputs ([#567](#567)) ### Src/ops/validate.rs - Common-up some type row calculations ([#254](#254)) </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Agustín Borgna <121866228+aborgna-q@users.noreply.github.com>

ss2165 requested a review from cqc-alec August 22, 2023 16:27

ss2165 commented Aug 22, 2023

View reviewed changes

acl-cqc reviewed Aug 23, 2023

View reviewed changes

cqc-alec reviewed Aug 23, 2023

View reviewed changes

ss2165 mentioned this pull request Aug 23, 2023

Rename Predicate/SimplePredicate (to Choice + UnitChoice?) #448

Closed

ss2165 changed the title ~~[RFC] define new TypeParam::SimplePredicate and use in int extension~~ Change TypeParam::USize to TypeParam::BoundedUSize and use in int extensions Aug 23, 2023

ss2165 force-pushed the new/int-width-sum branch from d05c0c3 to 9021a17 Compare August 23, 2023 13:41

ss2165 requested review from acl-cqc and cqc-alec August 23, 2023 13:43

ss2165 marked this pull request as ready for review August 23, 2023 13:43

ss2165 added 5 commits August 23, 2023 14:43

[RFC] define new TypeParam::SimplePredicate and use in int extension

e5799c2

remove USize + SimplePredicate in favour of BoundedUSize

b5d84fe

fixup constants and tests

1f9265d

pass args to integer directly

43b4432

change bound to maximum to be consistent with underlying int

db5c4f4

and fix doclinks

ss2165 force-pushed the new/int-width-sum branch from 9021a17 to db5c4f4 Compare August 23, 2023 13:43

cqc-alec requested changes Aug 23, 2023

View reviewed changes

acl-cqc reviewed Aug 23, 2023

View reviewed changes

ss2165 and others added 6 commits August 23, 2023 17:03

fix incorrect arguments

66f74a0

Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>

use log_width more

b659bcc

fix bug in unary ops

3033406

use correct type param for int ops

007967b

define array of valid integer types

e3a3182

edit type params in spec

7b2edea

ss2165 requested a review from acl-cqc August 23, 2023 16:41

cqc-alec approved these changes Aug 24, 2023

View reviewed changes

src/std_extensions/arithmetic/int_types.rs Outdated Show resolved Hide resolved

ss2165 and others added 2 commits August 24, 2023 09:16

fix typo

d2decaa

Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>

use NonZeroU64 to make bound non-exclusive

d13a4c1

ss2165 requested a review from cqc-alec August 24, 2023 09:40

rename BoundedUSize to BoundedNat

373a581

ss2165 force-pushed the new/int-width-sum branch from 29f54cb to 373a581 Compare August 24, 2023 09:43

cqc-alec reviewed Aug 24, 2023

View reviewed changes

ss2165 changed the title ~~Change TypeParam::USize to TypeParam::BoundedUSize and use in int extensions~~ feat: Change TypeParam::USize to TypeParam::BoundedNat and use in int extensions Aug 24, 2023

ss2165 added this pull request to the merge queue Aug 24, 2023

Merged via the queue into main with commit fa1e311 Aug 24, 2023
6 checks passed

ss2165 deleted the new/int-width-sum branch August 24, 2023 10:34

github-actions bot mentioned this pull request Jan 3, 2024

chore: release v0.1.0 #766

Merged

feat: Change TypeParam::USize to TypeParam::BoundedNat and use in int extensions #445

feat: Change TypeParam::USize to TypeParam::BoundedNat and use in int extensions #445

Conversation

ss2165 commented Aug 22, 2023 • edited Loading

ss2165 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acl-cqc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cqc-alec Aug 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

feat: Change `TypeParam::USize` to `TypeParam::BoundedNat` and use in int extensions #445

feat: Change `TypeParam::USize` to `TypeParam::BoundedNat` and use in int extensions #445

ss2165 commented Aug 22, 2023 •

edited

Loading

ss2165 left a comment •

edited

Loading

cqc-alec Aug 23, 2023 •

edited

Loading