Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tket2-hseries): cli extension dumping #584

Merged
merged 19 commits into from
Sep 9, 2024
Merged

feat(tket2-hseries): cli extension dumping #584

merged 19 commits into from
Sep 9, 2024

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Sep 4, 2024 •
edited
Loading

Closes #556

@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 82.45%. Comparing base (d9deacb) to head (e600f68).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tket2-hseries/src/bin/tket2-hseries.rs 0.00% 17 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
- Coverage   82.66%   82.45%   -0.22%     
==========================================
  Files          46       47       +1     
  Lines        6496     6513      +17     
  Branches     6496     6513      +17     
==========================================
  Hits         5370     5370              
- Misses        765      782      +17     
  Partials      361      361
Flag Coverage Δ
rust 82.45% <0.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ss2165 and others added 3 commits September 4, 2024 14:53
@ss2165
fix!: quantum extension name wrong way round (#582)
7bc2fb5 
BREAKING CHANGE: quantum extension renamed from "quantum.tket2" to
"tket2.quantum"
@ss2165
fix and format
988f5d5
@ss2165
Merge branch 'main' into doug/tket2-hseries-cli
bf1462a
@aborgna-q
Copy link
Collaborator

Don't forget to add the angles extension too

@ss2165
Copy link
Member Author

ss2165 commented Sep 5, 2024

unpushed commit 😅

@ss2165 ss2165 mentioned this pull request Sep 6, 2024
Closed
@ss2165 ss2165 added this to the tket2 0.3.0 / tket2-py 0.4.0 milestone Sep 9, 2024
@ss2165 ss2165 marked this pull request as ready for review September 9, 2024 11:34
@ss2165 ss2165 requested a review from a team as a code owner September 9, 2024 11:34
@ss2165 ss2165 requested a review from doug-q September 9, 2024 11:34
@ss2165 ss2165 changed the title feat: cli extension dumping feat(tket2-hseries):cli extension dumping Sep 9, 2024
@ss2165 ss2165 changed the title feat(tket2-hseries):cli extension dumping feat(tket2-hseries): cli extension dumping Sep 9, 2024
doug-q
doug-q reviewed Sep 9, 2024
View reviewed changes
tket2-hseries/Cargo.toml
cli = ["dep:clap", "dep:hugr-cli", "dep:clap-verbosity-flag", "dep:clio"]

[[bin]]
name = "tket2-hseries"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To extend the hugr cli this should be called something prefixed with hugr-

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this naturally extends the hugr cli, I think its fine stand alone for now. It's main use is within the repo anyway (using the justfile)

tket2-hseries/Cargo.toml Outdated
@@ -24,6 +32,10 @@ strum.workspace = true
strum_macros.workspace = true
thiserror.workspace = true
itertools.workspace = true
clap = { workspace = true, optional = true}
hugr-cli = { version = "*", optional = true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these versions need to be fixed

tket2-hseries/src/cli.rs Outdated
#[derive(Parser, Debug)]
#[clap(version = "1.0", long_about = None)]
#[clap(about = "HUGR CLI tools.")]
#[group(id = "hugr")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right? also I don't think version is right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@doug-q doug-q mentioned this pull request Sep 9, 2024
Merged
@ss2165 ss2165 requested a review from doug-q September 9, 2024 12:07
@ss2165 ss2165 added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit abf292f Sep 9, 2024
15 of 16 checks passed
@ss2165 ss2165 deleted the ss/ext-cli branch September 9, 2024 12:20
github-merge-queue bot pushed a commit that referenced this pull request Sep 9, 2024
@hugrbot
chore: release v0.3.0 (#595)
d90b815 
## 🤖 New release
* `tket2`: 0.2.0 -> 0.3.0
* `tket2-hseries`: 0.2.0 -> 0.3.0

<details><summary><i><b>Changelog</b></i></summary><p>

## `tket2`
<blockquote>

##
[0.3.0](tket2-v0.2.0...tket2-v0.3.0)
- 2024-09-09

### Bug Fixes

- extension ops checking against incorrect name
([#593](#593))
- [**breaking**] remove TryFrom for extension ops use `cast`
([#592](#592))
- don't load angle extensions on to quantum
([#597](#597))

### New Features

- [**breaking**] move angle types + and ops to new "tket2.angle"
extension ([#591](#591))
- dataflow builder methods for angle ops
([#596](#596))
- lowering tk2ops -> hseriesops
([#579](#579))
</blockquote>

## `tket2-hseries`
<blockquote>

##
[0.3.0](tket2-hseries-v0.2.0...tket2-hseries-v0.3.0)
- 2024-09-09

### Bug Fixes

- extension ops checking against incorrect name
([#593](#593))
- [**breaking**] remove TryFrom for extension ops use `cast`
([#592](#592))

### New Features

- lowering tk2ops -> hseriesops
([#579](#579))
- *(tket2-hseries)* cli extension dumping
([#584](#584))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
@hugrbot hugrbot mentioned this pull request Sep 10, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doug-q doug-q doug-q approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
tket2 0.3.0 / tket2-py 0.4.0
Development

Successfully merging this pull request may close these issues.

Create serialized extension definitions
3 participants
@ss2165 @aborgna-q @doug-q