fix: extension ops checking against incorrect name #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss2165
force-pushed
the
ss/fix-ext-name
branch
from
9e51b97
to
358b8ed
Compare
aborgna-q
approved these changes
Sep 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
==========================================
+ Coverage 82.94% 82.96% +0.01%
==========================================
Files 45 45
Lines 6214 6221 +7
Branches 6214 6221 +7
==========================================
+ Hits 5154 5161 +7
Misses 770 770
Partials 290 290
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lmondada
pushed a commit
that referenced
this pull request
Oct 1, 2024
## 🤖 New release * `tket2`: 0.2.0 -> 0.3.0 * `tket2-hseries`: 0.2.0 -> 0.3.0 <details><summary><i><b>Changelog</b></i></summary><p> ## `tket2` <blockquote> ## [0.3.0](tket2-v0.2.0...tket2-v0.3.0) - 2024-09-09 ### Bug Fixes - extension ops checking against incorrect name ([#593](#593)) - [**breaking**] remove TryFrom for extension ops use `cast` ([#592](#592)) - don't load angle extensions on to quantum ([#597](#597)) ### New Features - [**breaking**] move angle types + and ops to new "tket2.angle" extension ([#591](#591)) - dataflow builder methods for angle ops ([#596](#596)) - lowering tk2ops -> hseriesops ([#579](#579)) </blockquote> ## `tket2-hseries` <blockquote> ## [0.3.0](tket2-hseries-v0.2.0...tket2-hseries-v0.3.0) - 2024-09-09 ### Bug Fixes - extension ops checking against incorrect name ([#593](#593)) - [**breaking**] remove TryFrom for extension ops use `cast` ([#592](#592)) ### New Features - lowering tk2ops -> hseriesops ([#579](#579)) - *(tket2-hseries)* cli extension dumping ([#584](#584)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #588