Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for point clouds in Unity #197

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Add support for point clouds in Unity #197

merged 3 commits into from
Feb 6, 2023

Conversation

j9liu
Copy link
Contributor

@j9liu j9liu commented Feb 2, 2023

This PR builds off of CesiumGS/cesium-native#591 and adds support for rendering point clouds (pnts content) in Unity.

Some screenshots:

Melbourne Point Cloud
image
Mount St. Helen Church
image image

CesiumJS sandcastle with the above models for reference

@lilleyse
Copy link

lilleyse commented Feb 3, 2023

@j9liu this is exciting to see!

The colors look a bit faded and I wonder if you need to do an sRGB -> linear conversion in cesium-native. pnts is assumed to be sRGB whereas glTF vertex colors are assumed to be linear. I'm not sure what Unity expects as its input.

Peter ran into a similar issue in CesiumJS: CesiumGS/cesium#9978 (comment)

@j9liu
Copy link
Contributor Author

j9liu commented Feb 3, 2023

@lilleyse Thanks for the catch! It does look more accurate with the colors converted to linear space:
image
image

Will push my changes to cesium-native once I update the unit tests as well.

@j9liu j9liu mentioned this pull request Feb 3, 2023
@kring
Copy link
Member

kring commented Feb 6, 2023

Looks great!

@kring kring merged commit 2fc1b58 into main Feb 6, 2023
@kring kring deleted the pnts-support branch February 6, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants