Skip to content

Commit

Permalink
Merge pull request #10417 from CesiumGS/ext-color-buffer-float-fix
Browse files Browse the repository at this point in the history
Fixes the extension check required for OIT
  • Loading branch information
lilleyse authored Jun 1, 2022
2 parents bbaa82b + 431c7d1 commit acabb61
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 2 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- Removed individual image-based lighting parameters from `Model` and `Cesium3DTileset`. [#10388](https://github.com/CesiumGS/cesium/pull/10388)
- Models and tilesets rendered with `ModelExperimental` must set `enableDebugWireframe` to true in order for `debugWireframe` to work in WebGL1. [#10344](https://github.com/CesiumGS/cesium/pull/10344)
- Removed restriction on enabling `Scene.orderIndependentTranslucency` on iPad and iOS. [#10417](https://github.com/CesiumGS/cesium/pull/10417)

##### Additions :tada:

Expand All @@ -18,6 +19,7 @@

##### Fixes :wrench:

- Fixed the rendering issues related to order-independent translucency on iOS devices. [#10417](https://github.com/CesiumGS/cesium/pull/10417)
- Fixed the inaccurate computation of bounding spheres for models not centered at (0,0,0) in their local space. [#10395](https://github.com/CesiumGS/cesium/pull/10395)
- Fixed the inaccurate computation of bounding spheres for `ModelExperimental`. [#10339](https://github.com/CesiumGS/cesium/pull/10339/)
- Fixed error when destroying a 3D tileset before it has finished loading. [#10363](Fixes https://github.com/CesiumGS/cesium/issues/10363)
Expand Down
3 changes: 2 additions & 1 deletion Source/Scene/OIT.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ function OIT(context) {
this._translucentMultipassSupport = false;
this._translucentMRTSupport = false;

const extensionsSupported = context.colorBufferFloat && context.depthTexture;
const extensionsSupported =
context.colorBufferFloat && context.depthTexture && context.floatBlend;
this._translucentMRTSupport = context.drawBuffers && extensionsSupported;
this._translucentMultipassSupport =
!this._translucentMRTSupport && extensionsSupported;
Expand Down
5 changes: 1 addition & 4 deletions Source/Scene/Scene.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import destroyObject from "../Core/destroyObject.js";
import DeveloperError from "../Core/DeveloperError.js";
import EllipsoidGeometry from "../Core/EllipsoidGeometry.js";
import Event from "../Core/Event.js";
import FeatureDetection from "../Core/FeatureDetection.js";
import GeographicProjection from "../Core/GeographicProjection.js";
import GeometryInstance from "../Core/GeometryInstance.js";
import GeometryPipeline from "../Core/GeometryPipeline.js";
Expand Down Expand Up @@ -226,9 +225,7 @@ function Scene(options) {
this._computeCommandList = [];
this._overlayCommandList = [];

// OIT is temporally disabled by default on iPad and iOS mobile due to https://github.com/CesiumGS/cesium/issues/9827
const defaultOIT = !FeatureDetection.isIPadOrIOS();
this._useOIT = defaultValue(options.orderIndependentTranslucency, defaultOIT);
this._useOIT = defaultValue(options.orderIndependentTranslucency, true);
this._executeOITFunction = undefined;

this._depthPlane = new DepthPlane(options.depthPlaneEllipsoidOffset);
Expand Down

0 comments on commit acabb61

Please sign in to comment.