Fixes the extension check required for OIT #10417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @sanjeetsuhag!
Reviewers, don't forget to make sure that:
|
sanjeetsuhag
commented
Jun 1, 2022
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| ##### Fixes :wrench: | |||
|
|
|||
| - Fixed the rendering issues related to order-independent translucency on iOS devices. [#10417](https://github.com/CesiumGS/cesium/pull/10417) | |||
There was a problem hiding this comment.
Not sure if this is how we should phrase it or if it needs to go into breaking changes (since the workaround initially went in breaking changes)
There was a problem hiding this comment.
I would definitely add a bullet mentioning that the workaround has been removed. That new bullet probably belongs in breaking changes.
|
I can confirm this fixes the behavior on my iOS device which could reproduce the initial material issue. |
|
@sanjeetsuhag I think you have one eslint error to clean up. @lilleyse Could you confirm the fix? |
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9827 for more discussion.
Based on the information in this WebKit thread, this PR adds a check for
EXT_float_blendwhen enabling OIT. It also removes the restriction on OIT for iOS devices added as a workaround in #10337.Tested on an iPhone XR running iOS 15.5 using WebGL via Metal.