Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wall geometries with all negative heights do not render #4274

Closed
bmckilligan opened this issue Sep 1, 2016 · 13 comments · Fixed by #9041
Closed

Wall geometries with all negative heights do not render #4274

bmckilligan opened this issue Sep 1, 2016 · 13 comments · Fixed by #9041

Comments

@bmckilligan
Copy link

bmckilligan commented Sep 1, 2016

I need to represent wall geometries close to the ground surface with terrain turned on.

due to the geoid offset at particular locations the elevation for the top of the wall will be a negative value for the wall geometries since cesium is using ellipsoid elevations rather than orthometric.

a working example with two walls, the top of the red wall just above 0

https://sandcastle.cesium.com/#c=3ZNvT9swEMa/yilvSKXgJIOxrQvVSkGaNKQhxsYLwgs3Plpr/lOdnXRl4rvjJIUVOmlM2qs5kpU7/567ix+l4QSNxCUSHILBJUzQyVqzb10uLqOqiyfWeC4NUhkl8LM0AB6JQuaMbCMF0vBBWBFyj5eWlLjokXiQlOZu8L40/dOEllNV4yVXKjTtuzM0XnqJjnEh4q4DgOEaYQg7R4GGZYvvJP1JFwxhzbVrYV3QW+PgcZQJJx/euNljN2T1Mc4I0Y3DUKv4ajd/tceygzcJ7L9jeb6f/Cr1l2td6e260sH1YKOW5j+krvVHlLO5b2e7yrME8gyuNyFpnkGQsTxptydYuFiSXG18oVWW2NHp1xO2lH4+Vos5jzP2egAbMlt7Fazr2G3pePKpR++2TCIUL/foHEXnyn/gUMay9u7/5NFu62TYXmLR+cnxv3Ro7cettfrCxs/caZEoiQrnVwpHpfkg9cKSh5pUzFjqUS9UGNOl07r6jp5VrpMU6YOgELIBKQ5/8/NDpbhz4eSmVuqLvMUyGhVp4J/IlOVCmtnnBknxVYvM89Fpn2SMFWkIt1XeWjXl9FjxHg

for the red wall in the provided example change the maximumHeights line
from:
maximumHeights : [0.01, 0.01 ],

to
maximumHeights : [-0.01, -0.01 ],

the red wall no longer renders

@hpinkos
Copy link
Contributor

hpinkos commented Sep 6, 2016

Thanks for including the code example @bmckilligan!

@hpinkos hpinkos changed the title Wall geometries close to ground with terrain not rendering when top of wall <0 Wall geometries with all negative heights do not render Sep 6, 2016
@bmckilligan
Copy link
Author

the detail is, terrain needs to be turned on and the geographic location has a geoid offset height that is negative creating geometries that will be above ground, yet have negative maximumHeights

the particular location has a geoid height of around -20m

@jdurrie
Copy link

jdurrie commented Jul 17, 2017

I followed a link here from the Cesium in 2017 google doc. I want to find the issue that's tracking local bathymetry. Is there a better issue I'm not seeing?

@ggetz
Copy link
Contributor

ggetz commented Jul 17, 2017

@jdurrie You may want to take a look at the forum to find what you are looking for: https://groups.google.com/forum/#!searchin/cesium-dev/bathymetry%7Csort:relevance

@ggetz
Copy link
Contributor

ggetz commented Jul 21, 2017

@jdurrie I opened #5665 to track local bathymetry specifically, please add any details in that issue. Thanks!

@hpinkos
Copy link
Contributor

hpinkos commented Apr 3, 2020

Also reported by @vla9isla8 in #8724

@bmckilligan
Copy link
Author

Is there any chance this will get fixed? I would like to implement wall geometries with the new underground transparency in 1.70

@OmarShehata
Copy link
Contributor

This may be a good time to revisit now that CesiumJS has better support for underground. @hpinkos do you know what is causing this issue, or do you have any advice on where to start looking if someone wanted to investigate?

@hpinkos
Copy link
Contributor

hpinkos commented Jun 22, 2020

I don't know exactly, but I suspect it's something silly like we're clamping the positions to the ellipsoid somewhere. The best way to start looking into it would be to set breakpoints in WallGeometry/WallGeometryLibrary to see what it's spitting out for the positions values and how that differs from what's expected.

@bmckilligan
Copy link
Author

fingers crossed this fix will be in the next release

@hpinkos
Copy link
Contributor

hpinkos commented Jul 17, 2020

@bmckilligan that's the plan!

@bmckilligan
Copy link
Author

Fantastic, Thank you

@cesium-concierge
Copy link

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/forum/#!searchin/cesium-dev/bathymetry%7Csort

If this issue affects any of these threads, please post a comment like the following:

The issue at #4274 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants