Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolylineCollection limited to 16384 #5538

Closed
rahwang opened this issue Jun 27, 2017 · 4 comments
Closed

PolylineCollection limited to 16384 #5538

rahwang opened this issue Jun 27, 2017 · 4 comments

Comments

@rahwang
Copy link
Contributor

rahwang commented Jun 27, 2017

Reported on the forum: https://groups.google.com/d/msg/cesium-dev/exLJc20nQpI/6S_Kxs6pBQAJ

When adding large numbers of elements to a polyline collection, only the first 16384 show up.

Here's an example (should make a full circle):
http://cesiumjs.org/Cesium/Apps/Sandcastle/?src=Hello%20World.html&label=Showcases&gist=758939a9dea1f6f5bf4d14617d55fe6a

@mramato mramato changed the title Polyline collection limited to 16384 PolylineCollection limited to 16384 Jun 27, 2017
@fcayre
Copy link
Contributor

fcayre commented Aug 23, 2017

I tried to debug that one unsuccessfully until now. However I noticed:

  • this error in the console when the number of polylines is 20000 for instance: "bound vertex attribute buffers do not have sufficient size for given indices from the bound element array"; this error does not show up for a lower number of polylines (2000 for instance); so the vertex indices and position buffers do not match
  • when using an even greater number of polylines (100 000 for instance), only the last polylines do not show up, as if only the last polylines' bucket (as they are named in the code) was not displayed but hte others were.

I would greatly appreciate an idea to debug that, specific tools or debug options you might suggest, ...

@fcayre
Copy link
Contributor

fcayre commented Aug 24, 2017

OK we finally spotted an offset in the polyline indices buckets, a pull request should be submitted soon.

fcayre pushed a commit to fcayre/cesium that referenced this issue Aug 25, 2017
A 64K buffer limit overflow test was wrong, leading to out-of range vertice indices.
fcayre pushed a commit to fcayre/cesium that referenced this issue Aug 25, 2017
A 64K buffer limit overflow test was wrong, leading to out-of range vertice indices.
fcayre added a commit to fcayre/cesium that referenced this issue Sep 26, 2017
mramato added a commit that referenced this issue Sep 27, 2017
Fix PolylineCollection indices arrays (#5538)
@hpinkos
Copy link
Contributor

hpinkos commented Sep 19, 2019

Appears to be fixed

image

@hpinkos hpinkos closed this as completed Sep 19, 2019
@cesium-concierge
Copy link

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/d/msg/cesium-dev/exLJc20nQpI/6S_Kxs6pBQAJ

If this issue affects any of these threads, please post a comment like the following:

The issue at #5538 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants