Fix PolylineCollection indices arrays (#5538) #5782
Conversation
A 64K buffer limit overflow test was wrong, leading to out-of range vertice indices.
|
@fcayre, thanks for the pull request! I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to I am a bot who helps you make Cesium awesome! Thanks again. |
|
Hi @fcayre, thanks for the pull request! Could you please send in a Contributor License Agreement so we can review this? |
|
Hi @ggetz, you should have the document now, any update regarding the issue? |
|
@fcayre thanks again for the contribution! I did not see your CLA, could you try emailing it directly to me: pcozzi@agi.com. Thanks! |
|
We now have a CLA from @fcayre, thanks! |
| @@ -152,4 +152,5 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for details on how to contribute to Cesiu | |||
| * [Rishabh Shah](https://github.com/rms13) | |||
| * [Rudraksha Shah](https://github.com/Rudraksha20) | |||
| * [Cody Guldner](https://github.com/burn123) | |||
| * [Florent Cayré](https://github.com/fcayre) | |||
There was a problem hiding this comment.
Can you please add yourself under the corporate CLA section?
|
Thanks @fcayre, looks good! Please update CHANGES.md with the bug you fixed and this is all good to go! |
|
@ggetz done, thanks. |
|
@pjcozzi I think this is good to merge |
|
Verified the error is gone. Thanks @fcayre! |
Fix PolylineCollection indices arrays (#5538)
A 64K buffer limit overflow test was wrong, leading to out-of range vertice indices.
Current PolylineCollection tests are not broken by the change, which calls for a new or updated test.