Firefox 59.0 on macOS ctrl+touchpad rotation not working

[andrzejfigula]

Latest Firefox broke navigation control (ctrl + touchpad to rotate) for macbook.
This was only checked with touchpad, not sure if affects other pointing devices.

Environment:

• macOS (Sierra) on MacBook Pro (Retina, 15-inch, Mid 2014)
• Firefox 59.0.2 (64-bit)
• Cesium 1.43 (Cesium home page and my application)

Issue:
I'm always using touchpad to rotate (ctrl + touch), it was always possible on FF until last update.
(Chrome and Safari works fine).

Tested on Cesium home page and with Cesium 1.43

Looking at FF release notes:
https://www.mozilla.org/en-US/firefox/59.0/releasenotes/

I found this:
"Added support for W3C specs for pointer events and improved platform integration with added device support for mouse, pen, and touch screen pointer input"

Just guessing this might be the reason.

[hpinkos]

Thanks for reporting this @andrzejfigula!
@ggetz can you confirm this bug on your mac?

[jimmyangel]

I can confirm this issue as well on Firefox 59.0.2 MacOS 10.13.4, Cesium 1.44. Control-drag not working work with a trackpad nor a mouse either.

[hpinkos]

Thanks @jimmyangel. Can someone with a mac confirm this bug? @shehzan10 @tfili @shunter?

[shrichards]

I'm also seeing this on my MacBook Pro (exact same specs as @andrzejfigula) with Cesium 1.44 & FireFox v60.0b13 beta.

With a mouse hooked up, ctrl-leftclick-drag also doesn't work. However, ctrl-rightclick-drag does rotate.

[hpinkos]

Thanks @shrichards, we'll try to look into this soon

[DronePhil]

@hpinkos any updates here? At DroneDeploy we are starting to see customer complaints about this issue. Though we can fix it by rewriting the camera controls ourselves, we'd prefer not to.

[mramato]

I believe Firefox has several bugs in the PointerEvents implementation, we've encountered this before in our own unit tests. I think the best solution here is to disable PointerEvents completely in FireFox until those issues get fixed.

I'll push a branch with this change and if folks can confirm that it fixes the issue, we'll merge for the next release.

[mramato]

Since I can't reproduce this, can anyone with this issue try http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/dont-point/ (That has both the Viewer sample app and Sandcastle) and report whether it fixes the issue?

If so, I think we can squeeze this into the next release (tomorrow!) but we need to know if it works ASAP.

[ggetz]

Can't duplicate on my machine, can @likangning93 or someone else with macOS?

[mramato]

@ggetz do you mean you can't reproduce this in master either?

[ggetz]

@mramato Yes, I can't reproduce this in master.

[mramato]

@andrzejfigula, @DronePhil, @shrichards @jimmyangel Can any of you still reproduce this, either in master at http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/master/ or on the branch I linked to above (http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/dont-point/)

[likangning93]

Just tested on Firefox 61.0.2 x64 on macOS 10.11.6, ctrl + trackpad worked for the dont-point branch but not in master

[mramato]

Thanks @likangning93! Once my PR is merged I'll write up a new issue to re-enable PointEvents in FF once they fix them.

[mramato]

Wrote up #7003 to revisit this issue once Firefox improves their implementation (or we find out it was something we are doing on our end)