Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable PointerEvents in Firefox until they work. #6999

Merged
merged 2 commits into from
Sep 4, 2018
Merged

Disable PointerEvents in Firefox until they work. #6999

merged 2 commits into from
Sep 4, 2018

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Sep 3, 2018

We previously only disabled them in tests for #6539, but #6372 indicates the problem may be more widespread.

We previously only disabled them in tests for #6539, but #6372 indicates
the problem may be more widespread.
@cesium-concierge
Copy link

Thanks for the pull request @mramato!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@mramato
Copy link
Contributor Author

mramato commented Sep 3, 2018

CC @ggetz If the users encountering this issue in #6372 get back to us in time, we should definitely merge this for the release.

If we don't hear back by release time, we can punt to next month.

@ggetz
Copy link
Contributor

ggetz commented Sep 4, 2018

Thanks @mramato. Can you also update CHANGES.md? Then this should be good to go.

@mramato
Copy link
Contributor Author

mramato commented Sep 4, 2018

Ready

@ggetz
Copy link
Contributor

ggetz commented Sep 4, 2018

Thanks again!

@ggetz ggetz merged commit 36e42b7 into master Sep 4, 2018
@ggetz ggetz deleted the dont-point branch September 4, 2018 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants