-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BingMapsGeocoderService crashes since Cesium 1.49 #7143
Comments
I can confirm this crash. Looks like you don't even need to change anything, it even happens in the Hello World.html. All you have to be doing is using the So far I've narrowed it to down This also came up on the forum. |
There were a few changes for the 1.49 and 1.50 releases but it was mostly reorganizing code. Nothing jumped out at me that would be causing an issue. |
@mramato do you think this could be related to your geocoder fly to changes? |
Yes, this has nothing directly to do with Bing, it's just getting triggered by their results. I'll open a PR as soon as I get a chance. |
Also added |
Not sure what I was thinking when I wrote `computeFlyToLocationForRectangle`, but this changes it so it always returns a `Cartographic`. Previously it would return a Rectangle if terrain wasn't set or didn't have `availability` which just made the calling code confusing for no reason and lead to #7143. `computeFlyToLocationForRectangle` is private, so this isn't a breaking change. Fixes #7143
Congratulations on closing the issue! I found these Cesium forum links in the comments above: https://groups.google.com/d/msg/cesium-dev/y5tWLNuf--8/PcuJd-cPAgAJ If this issue affects any of these threads, please post a comment like the following:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
Thanks for the bug report @SunBlack! This has been fixed and will be included in the 1.51 release available November 1st. |
Since Cesium 1.45 BingMapsGeocoderService is no longer the default geocoding service. In changelog following changes are recommend in case you want still use it
This works fine until Cesium 1.48. But with 1.49 & 1.50 you got following error with this if you search for a city:
The text was updated successfully, but these errors were encountered: