-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete SpecRunner Jasmine files #10184
Conversation
Thanks for the pull request @ebogo1!
Reviewers, don't forget to make sure that:
|
Also - should there be a CHANGES.md entry for this? |
Let's add it for completeness since we removed the test link from |
Thanks @ebogo1! The functional part of this PR is all working as expected. Let's just make sure the testing guide still has all the necessary info before merging this. |
Looks good! Thanks again @ebogo1 ! |
Another part of #10134 - after this PR the only work left should be to update the Jasmine version we get from npm and clean up our matchers/syntax in specs if needed.
This gets rid of: